[tor-commits] [tor/master] Remove FIXME about comparing num countries,

[dgoulet@xxxxxxxxxxxxxx]

commit 96469b82f8d27f9c69d863799b624c93cd1ea6f0
Author: juga0 <juga@xxxxxxxxxx>
Date:   Tue Apr 17 16:38:24 2018 +0000

    Remove FIXME about comparing num countries,
    
    * remove the fixme since clearing the countries should be other issue
    * remove unused variables related to it since that cause travis to fail
---
 src/test/test_geoip.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/test/test_geoip.c b/src/test/test_geoip.c
index fa5916c05..f5949f755 100644
--- a/src/test/test_geoip.c
+++ b/src/test/test_geoip.c
@@ -511,16 +511,10 @@ test_geoip_load_2nd_file(void *arg)
   const char FNAME[] = SRCDIR "/src/config/geoip";
   tt_int_op(0, OP_EQ, geoip_load_file(AF_INET, FNAME));
 
-  int num_countries_geoip = geoip_get_n_countries();
-
   /* Load 2nd geoip (empty) file */
   const char FNAME2[] = SRCDIR "/src/test/geoip_dummy";
   tt_int_op(0, OP_EQ, geoip_load_file(AF_INET, FNAME2));
 
-  int num_countries_geoip2 = geoip_get_n_countries();
-  /* FIXME: should not this be different? */
-  /* tt_int_op(num_countries_geoip, OP_NE, num_countries_geoip2); */
-
   /* Check that there is no geoip information for 8.8.8.8, */
   /* since loading the empty 2nd file should have delete it. */
   int country = geoip_get_country_by_ipv4(0x08080808);
@@ -551,4 +545,3 @@ struct testcase_t geoip_tests[] = {
 
   END_OF_TESTCASES
 };
-



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits