[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-149.0a1-16.0-2] fixup! BB 40926: Implemented the New Identity feature

Title: GitLab

ma1 pushed to branch tor-browser-149.0a1-16.0-2 at The Tor Project / Applications / Tor Browser

Commits:

  • 8244638a
    by hackademix at 2026-04-15T17:54:03+02:00 
    fixup! BB 40926: Implemented the New Identity feature

BB 44288: Regression, custom home page not blocked anymore on new identity.

2 changed files:

Changes:

  • browser/components/newidentity/content/newidentity.js
    ... ... @@ -402,7 +402,8 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => {
    402 402 
             const isCustomHome =
    403 403 
               Services.prefs.getIntPref("browser.startup.page") === 1;
    404 404 
             const win = OpenBrowserWindow({
    405 
    -          private: isCustomHome && isTrustedHome ? "private" : "no-home",
    405 
    +          private: true,
    406 
    +          skipCustomHome: !(isCustomHome && isTrustedHome),
    406 407 
             });
    407 408 
             // This mechanism to know when the new window is ready is used by
    408 409 
             // OpenBrowserWindow itself (see its definition in browser.js).
    ... ... @@ -435,7 +436,7 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => {
    435 436 
                   }
    436 437 
                   const callback = () => {
    437 438 
                     Services.prefs.setStringPref(trustedHomePref, homeURL);
    438 
    -                win.BrowserHome();
    439 
    +                win.BrowserCommands.home();
    439 440 
                   };
    440 441 
                   const notificationBox = win.gBrowser.getNotificationBox();
    441 442 
                   notificationBox.appendNotification(

  • browser/modules/BrowserWindowTracker.sys.mjs
    ... ... @@ -330,6 +330,7 @@ export const BrowserWindowTracker = {
    330 330 
           args = null,
    331 331 
           remote = undefined,
    332 332 
           fission = undefined,
    333 
    +      skipCustomHome = false,
    333 334 
         } = options;
    334 335
    335 336 
         args = lazy.AIWindow.handleAIWindowOptions(options);
    ... ... @@ -346,7 +347,7 @@ export const BrowserWindowTracker = {
    346 347 
           windowFeatures += ",private";
    347 348 
           if (
    348 349 
             (!args && !lazy.PrivateBrowsingUtils.permanentPrivateBrowsing) ||
    349 
    -        args?.private === "no-home"
    350 
    +        skipCustomHome
    350 351 
           ) {
    351 352 
             // Force the new window to load about:privatebrowsing instead of the
    352 353 
             // default home page.

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8244638a9474a9d3cf7acb1e2b5b04bedd02f565 at 1776273678 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx