[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-140.10.0esr-15.0-1] fixup! BB 40926: Implemented the New Identity feature

Title: GitLab

ma1 pushed to branch tor-browser-140.10.0esr-15.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 1fb85f39
    by hackademix at 2026-04-16T09:30:39+02:00 
    fixup! BB 40926: Implemented the New Identity feature

BB 44288: Regression, custom home page not blocked anymore on new identity.

2 changed files:

Changes:

  • browser/components/newidentity/content/newidentity.js
    ... ... @@ -402,7 +402,8 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => {
    402 402 
             const isCustomHome =
    403 403 
               Services.prefs.getIntPref("browser.startup.page") === 1;
    404 404 
             const win = OpenBrowserWindow({
    405 
    -          private: isCustomHome && isTrustedHome ? "private" : "no-home",
    405 
    +          private: true,
    406 
    +          skipCustomHome: !(isCustomHome && isTrustedHome),
    406 407 
             });
    407 408 
             // This mechanism to know when the new window is ready is used by
    408 409 
             // OpenBrowserWindow itself (see its definition in browser.js).
    ... ... @@ -435,7 +436,7 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => {
    435 436 
                   }
    436 437 
                   const callback = () => {
    437 438 
                     Services.prefs.setStringPref(trustedHomePref, homeURL);
    438 
    -                win.BrowserHome();
    439 
    +                win.BrowserCommands.home();
    439 440 
                   };
    440 441 
                   const notificationBox = win.gBrowser.getNotificationBox();
    441 442 
                   notificationBox.appendNotification(

  • browser/modules/BrowserWindowTracker.sys.mjs
    ... ... @@ -296,6 +296,7 @@ export const BrowserWindowTracker = {
    296 296 
         args = null,
    297 297 
         remote = undefined,
    298 298 
         fission = undefined,
    299 
    +    skipCustomHome = false,
    299 300 
       } = {}) {
    300 301 
         let windowFeatures = "chrome,dialog=no,all";
    301 302 
         if (features) {
    ... ... @@ -306,7 +307,7 @@ export const BrowserWindowTracker = {
    306 307 
           windowFeatures += ",private";
    307 308 
           if (
    308 309 
             (!args && !lazy.PrivateBrowsingUtils.permanentPrivateBrowsing) ||
    309 
    -        args?.private === "no-home"
    310 
    +        skipCustomHome
    310 311 
           ) {
    311 312 
             // Force the new window to load about:privatebrowsing instead of the
    312 313 
             // default home page.

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1fb85f3941c679c3b0a9e7b7f0abaf537c94ba70 at 1776324670 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx