[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-149.0a1-16.0-2] 4 commits: fixup! TB 23247: Communicating security expectations for .onion

Title: GitLab

henry pushed to branch tor-browser-149.0a1-16.0-2 at The Tor Project / Applications / Tor Browser

Commits:

  • bddfb109
    by Henry Wilkes at 2026-04-16T16:25:52+00:00 
    fixup! TB 23247: Communicating security expectations for .onion

TB 43857: Drop TODO since it is "won't do".
  • 184592ac
    by Henry Wilkes at 2026-04-16T16:25:52+00:00 
    fixup! TB 43564: Modify ./mach bootstrap for Tor Browser

TB 43857: Drop TODO since it is "won't do".
  • 112b814b
    by Henry Wilkes at 2026-04-16T16:25:52+00:00 
    fixup! [android] Disable features and functionality

TB 43857: Drop TODO since it is "won't do".
  • 8956c706
    by Henry Wilkes at 2026-04-16T16:25:52+00:00 
    fixup! TB 42247: Android helpers for the TorProvider

TB 43857: Update TODO and FIXME comments.

4 changed files:

Changes:

  • browser/base/content/browser-siteIdentity.js
    ... ... @@ -929,7 +929,6 @@ var gIdentityHandler = {
    929 929 
               uriIsOnionHost ? "onionMixedDisplayContent" : "mixedDisplayContent"
    930 930 
             );
    931 931 
           } else {
    932 
    -        // TODO: ignore weak https cipher for onionsites?
    933 932 
             this._identityBox.classList.add("weakCipher");
    934 933 
           }
    935 934 
         } else if (this._isCertErrorPage) {

  • build/moz.configure/torbrowser-resources.configure
    ... ... @@ -24,7 +24,6 @@ option(
    24 24 
     def tor_expert_bundle(value, mozbuild_state_path, _bootstrapped):
    25 25 
         if value:
    26 26 
             path = Path(value[0])
    27 
    -        # TODO: Do a more thorough check on the directory.
    28 27 
             if path.is_dir():
    29 28 
                 return value[0]
    30 29 
             else:

  • mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessor.kt
    ... ... @@ -133,10 +133,6 @@ class HomeDeepLinkIntentProcessor(
    133 133 
                     }
    134 134 
                     if (BuildConfig.DEEP_LINK_SCHEME.startsWith("torbrowser")) {
    135 135 
                         // tor-browser#42578
    136 
    -                    // TODO:
    137 
    -                    // Maybe just warn users about linkability but
    138 
    -                    // give them the choice to open anyway, once
    139 
    -                    // the other deep link related issues are fixed.
    140 136 
                         logger.info("Tor Browser rejects open intent deep link: $deepLink")
    141 137 
                         return
    142 138 
                     }

  • mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java
    ... ... @@ -148,7 +148,14 @@ public class TorAndroidIntegration implements BundleEventListener {
    148 148 
         } else if (EVENT_SETTINGS_CHANGED.equals(event)) {
    149 149 
           GeckoBundle newSettings = message.getBundle("settings");
    150 150 
           if (newSettings != null) {
    151 
    -        // TODO: Should we notify listeners?
    151 
    +        // NOTE: We assume that we do not need to notify any consumer with the
    152 
    +        // new state because we expect the relevant consumers to read the latest
    153 
    +        // state regularly (e.g. each time the settings screen is opened), and
    154 
    +        // we only expect one active consumer at any given moment (only one
    155 
    +        // setting screen is shown) which means that the single consumer can
    156 
    +        // reflect any *expected* individual changes in the UI prior to this
    157 
    +        // confirmation signal, and there are no other consumers that need to be
    158 
    +        // synchronised with this change. See tor-browser#42384.
    152 159 
             mSettings = new TorSettings(newSettings);
    153 160 
           } else {
    154 161 
             Log.w(TAG, "Ignoring a settings changed event that did not have the new settings.");
    ... ... @@ -345,7 +352,7 @@ public class TorAndroidIntegration implements BundleEventListener {
    345 352 
             data.putInt("status", 0xdeadbeef);
    346 353 
           }
    347 354 
           // FIXME: We usually don't reach this when the application is killed!
    348 
    -      // So, we don't do our cleanup.
    355 
    +      // So, we don't do our cleanup. Investigation in tor-browser#44861.
    349 356 
           Log.i(TAG, "Tor process " + mHandle + " has exited.");
    350 357 
           EventDispatcher.getInstance().dispatch(EVENT_TOR_EXITED, data);
    351 358 
         }

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/723952b86ef6f9323846f5b74eb68d179be8f2d8...8956c7060c0475bda4e962b9b5f6552fbff743cf at 1776356788 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx