[tor-commits] [onionoo/master] Fix stupid boolean logic fail.

[karsten@xxxxxxxxxxxxxx]

commit 8c0b411537449b25ebb35cbac8e3cc4e3813f182
Author: Karsten Loesing <karsten.loesing@xxxxxxx>
Date:   Tue Aug 19 20:06:46 2014 +0200

    Fix stupid boolean logic fail.
    
    29109e2 introduced a bug that led to skipping server descriptors if they
    were newer than all server descriptors we parsed before; which is the
    opposite of what we're supposed to do.  Reported on tor-relays@.
---
 .../org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java   |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java b/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java
index 8d5ab0b..6341afd 100644
--- a/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java
+++ b/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java
@@ -107,7 +107,7 @@ public class NodeDetailsStatusUpdater implements DescriptorListener,
         DetailsStatus.class, true, fingerprint);
     if (detailsStatus == null) {
       detailsStatus = new DetailsStatus();
-    } else if (descriptor.getPublishedMillis() >
+    } else if (descriptor.getPublishedMillis() <=
         detailsStatus.getDescPublished()) {
       return;
     }
@@ -225,7 +225,7 @@ public class NodeDetailsStatusUpdater implements DescriptorListener,
         DetailsStatus.class, true, fingerprint);
     if (detailsStatus == null) {
       detailsStatus = new DetailsStatus();
-    } else if (detailsStatus.getDescPublished() >
+    } else if (detailsStatus.getDescPublished() <=
         descriptor.getPublishedMillis()) {
       return;
     }

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits