[tor-commits] [tor/master] Always log [bug] warnings from the unit tests.

[nickm@xxxxxxxxxxxxxx]

commit 273290d4fee31857d689ef5286e44dd268a9bd65
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Wed Aug 31 13:22:07 2016 -0400

    Always log [bug] warnings from the unit tests.
    
    We should consider them bugs.  If they are happening intentionally,
    we should use the log_test_helpers code to capture and suppress
    them.  But having them off-by-default has potential to cause
    programming errors.
---
 src/test/testing_common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/test/testing_common.c b/src/test/testing_common.c
index ea93663..e3fe87c 100644
--- a/src/test/testing_common.c
+++ b/src/test/testing_common.c
@@ -272,6 +272,8 @@ main(int c, const char **v)
     log_severity_list_t s;
     memset(&s, 0, sizeof(s));
     set_log_severity_config(loglevel, LOG_ERR, &s);
+    /* ALWAYS log bug warnings. */
+    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
     add_stream_log(&s, "", fileno(stdout));
   }
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits