[tor-commits] [tor/master] Fix a memory-leak warning in test_circuitbuid.c

[dgoulet@xxxxxxxxxxxxxx]

commit 0bf980705ec3e5a01197615619d62091d1e1f9c8
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Aug 19 16:21:55 2019 -0400

    Fix a memory-leak warning in test_circuitbuid.c
    
    Coverity wants us to free everything that we are potentially
    allocating, even stuff where allocating it would be a bug.  Adding
    a smartlist_free() here will fix the warning.
    
    Fixes bug 31452; bugfix on 16a0b7ed6779bf72a8a471c, which is not in
    any released Tor.  This is CID 1447292.
---
 src/test/test_circuitbuild.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/test/test_circuitbuild.c b/src/test/test_circuitbuild.c
index 196d8cd35..7291e04d6 100644
--- a/src/test/test_circuitbuild.c
+++ b/src/test/test_circuitbuild.c
@@ -167,6 +167,7 @@ test_upgrade_from_guard_wait(void *arg)
   tt_assert(!list);
 
  done:
+  smartlist_free(list);
   circuit_free(circ);
   entry_guard_free_(guard);
 }



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits