[tor-commits] [tor-browser] 28/179: Bug 1773223 - Remove variable expansion in the GN processor. r=firefox-build-system-reviewers, andi a=RyanVM

[gitolite role <git@xxxxxxxxxxxxxxxxxxxxx>]

This is an automated email from the git hooks/post-receive script.

pierov pushed a commit to branch tor-browser-102.2.0esr-12.0-1
in repository tor-browser.

commit d24ccd21af2bee20e3411c9295fa77047fbf301a
Author: Mike Hommey <mh+mozilla@xxxxxxxxxxxx>
AuthorDate: Mon Jun 20 21:50:58 2022 +0000

    Bug 1773223 - Remove variable expansion in the GN processor. r=firefox-build-system-reviewers,andi a=RyanVM
    
    This was cargo culted from the gyp processor, but is not used.
    
    Differential Revision: https://phabricator.services.mozilla.com/D149206
---
 python/mozbuild/mozbuild/gn_processor.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/python/mozbuild/mozbuild/gn_processor.py b/python/mozbuild/mozbuild/gn_processor.py
index c59edde0734ce..1598c53b9f756 100644
--- a/python/mozbuild/mozbuild/gn_processor.py
+++ b/python/mozbuild/mozbuild/gn_processor.py
@@ -17,7 +17,7 @@ from mozbuild.backend.base import BuildBackend
 import mozpack.path as mozpath
 from mozbuild.frontend.sandbox import alphabetical_sorted
 from mozbuild.frontend.data import GnProjectData
-from mozbuild.util import expand_variables, mkdir
+from mozbuild.util import mkdir
 
 
 license_header = """# This Source Code Form is subject to the terms of the Mozilla Public
@@ -325,12 +325,6 @@ def process_gn_config(
             variables = (suffix_map[e] for e in extensions if e in suffix_map)
             for var in variables:
                 for f in flags:
-                    # We may be getting make variable references out of the
-                    # gn data, and we don't want those in emitted data, so
-                    # substitute them with their actual value.
-                    f = expand_variables(f, config.substs).split()
-                    if not f:
-                        continue
                     # the result may be a string or a list.
                     if isinstance(f, six.string_types):
                         context_attrs.setdefault(var, []).append(f)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits