[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 41600: Add a tor circuit display panel.



Title: GitLab

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 95ec0dcc
    by Henry Wilkes at 2024-08-07T21:39:39+00:00
    fixup! Bug 41600: Add a tor circuit display panel.
    
    Bug 42488: Remove redundant role="code" from ip address <code> element.
    
    After ESR 128, the <code> element has an implicit "code" accessible
    role.
    

1 changed file:

Changes:

  • browser/components/torcircuit/content/torCircuitPanel.js
    ... ... @@ -617,19 +617,10 @@ var gTorCircuitPanel = {
    617 617
           } else {
    
    618 618
             addressesEl.append(", ");
    
    619 619
           }
    
    620
    +      // Use semantic <code> block for the ip addresses, so the content
    
    621
    +      // (especially punctuation) can be better interpreted by screen readers,
    
    622
    +      // if they support this.
    
    620 623
           const ipEl = document.createElement("code");
    
    621
    -      // TODO: Current HTML-aam 1.0 specs map the <code> element to the "code"
    
    622
    -      // role.
    
    623
    -      // However, mozilla-central commented out this mapping in
    
    624
    -      // accessible/base/HTMLMarkupMap.h because the HTML-aam specs at the
    
    625
    -      // time did not do this.
    
    626
    -      // See hg.mozilla.org/mozilla-central/rev/51eebe7d6199#l2.12
    
    627
    -      //
    
    628
    -      // This was updated in mozilla bug 1834931, for ESR 128
    
    629
    -      //
    
    630
    -      // For now we explicitly add the role="code", but once this is fixed
    
    631
    -      // from mozilla-central we should remove this.
    
    632
    -      ipEl.setAttribute("role", "code");
    
    633 624
           ipEl.classList.add("tor-circuit-ip-address");
    
    634 625
           ipEl.textContent = ip;
    
    635 626
           addressesEl.append(ipEl);
    

  • _______________________________________________
    tor-commits mailing list
    tor-commits@xxxxxxxxxxxxxxxxxxxx
    https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits