[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 40309: Avoid using regional OS locales

Title: GitLab

Pier Angelo Vendrame pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 98b8bdd4
    by Pier Angelo Vendrame at 2024-08-08T19:12:40+02:00 
    fixup! Bug 40309: Avoid using regional OS locales

Bug 42349: Change the RFPTarget in the region spoofing.

One of our patches makes sure that when spoof English is not in use, we
report the same locale as the app language, instead of reporting the OS
locale (which is Firefox's default behavior when the app and OS
languages are the same).

When rebasing onto 128, we broke this patch because we had to specify
an RFPTarget, and I chose RFPTarget::JSLocale.
This is the only target that can be disabled even when running RFP
instead of FFP, because it is controlled by privacy.spoof_english.
  • 402c32c1
    by Pier Angelo Vendrame at 2024-08-08T19:12:56+02:00 
    fixup! Firefox preference overrides.

Add some notes about live-reload, discovered while investigating some
localization issues.

2 changed files:

Changes:

  • browser/app/profile/001-base-profile.js
    ... ... @@ -624,6 +624,9 @@ pref("corroborator.enabled", false);
    624 624
    625 625 
     // tor-browser#41417: do not allow live reload until we switch to Fluent and
    626 626 
     // stop using .textContent.
    627 
    +// Even after that, it might be a good idea to keep it off, as it is not handled
    628 
    +// very well, and it might give a window during which websites could fingerprint
    629 
    +// the change (see tor-browser#42349 and tor-browser#42771).
    627 630 
     pref("intl.multilingual.liveReload", false);
    628 631
    629 632 
     // Enable URL query stripping to protect against cross-site tracking (tor-browser#41092)

  • intl/locale/LocaleService.cpp
    ... ... @@ -485,10 +485,12 @@ LocaleService::GetAppLocaleAsBCP47(nsACString& aRetVal) {
    485 485
    486 486 
     NS_IMETHODIMP
    487 487 
     LocaleService::GetRegionalPrefsLocales(nsTArray<nsCString>& aRetVal) {
    488 
    +  // tor-browser#42349, #42771: We cannot use JSLocale because it is spoof
    489 
    +  // English. So, we use another target for now.
    488 490 
       if (nsContentUtils::ShouldResistFingerprinting(
    489 491 
               "This is probably a patch that should be refined. But to get the "
    490 492 
               "build going, we just keep applying this generic check.",
    491 
    -          RFPTarget::JSLocale)) {
    493 
    +          RFPTarget::JSDateTimeUTC)) {
    492 494 
         GetAppLocalesAsBCP47(aRetVal);
    493 495 
         return NS_OK;
    494 496 
       }

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits