[or-cvs] document aborted attempt to merge client dns cache with ser...

[arma@seul.org (Roger Dingledine)]

Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	connection_edge.c 
Log Message:
document aborted attempt to merge client dns cache with server dns cache


Index: connection_edge.c
===================================================================
RCS file: /home/or/cvsroot/src/or/connection_edge.c,v
retrieving revision 1.73
retrieving revision 1.74
diff -u -d -r1.73 -r1.74
--- connection_edge.c	14 Dec 2003 07:40:47 -0000	1.73
+++ connection_edge.c	14 Dec 2003 07:50:45 -0000	1.74
@@ -838,6 +838,11 @@
 /* ***** Client DNS code ***** */
 
 /* XXX Perhaps this should get merged with the dns.c code somehow. */
+/* XXX But we can't just merge them, because then nodes that act as
+ *     both OR and OP could be attacked: people could rig the dns cache
+ *     by answering funny things to stream begin requests, and later
+ *     other clients would reuse those funny addr's. Hm.
+ */
 struct client_dns_entry {
   SPLAY_ENTRY(client_dns_entry) node;
   char *address;