[tor-commits] [tor/master] Add comment about bug4651 fix

[nickm@xxxxxxxxxxxxxx]

commit 15d99fe4eb0e969322f401bc5d5b497d5cfc9f71
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Dec 5 11:29:43 2011 -0500

    Add comment about bug4651 fix
---
 src/or/circuituse.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/src/or/circuituse.c b/src/or/circuituse.c
index 0bc416d..bdff75c 100644
--- a/src/or/circuituse.c
+++ b/src/or/circuituse.c
@@ -1017,6 +1017,14 @@ circuit_has_opened(origin_circuit_t *circ)
   switch (TO_CIRCUIT(circ)->purpose) {
     case CIRCUIT_PURPOSE_C_ESTABLISH_REND:
       rend_client_rendcirc_has_opened(circ);
+      /* XXXX We'd like to set something like "can_try_clearing_isolation"
+       * here, so that we can change the isolation of this circuit (and maybe
+       * its purpose too) if it turns out that we no longer have any streams
+       * that want to use it.  But connection_ap_attach_pending() doesn't
+       * actually attach streams to a C_ESTABLISH_REND circuit-- streams
+       * don't get attached until the circuit is in C_REND_JOINED... so
+       * we can't clear isolation now.
+       */
       connection_ap_attach_pending();
       break;
     case CIRCUIT_PURPOSE_C_INTRODUCING:

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits