[tor-commits] [tor/master] Revert "indent; add comment"

[nickm@xxxxxxxxxxxxxx]

commit 75134c6c86e54c10fd9e11c4345aadcdabc0f8fb
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue Dec 6 19:49:20 2011 -0500

    Revert "indent; add comment"
    
    This reverts commit 40a87c4c08be0cdd87a3df283f285b3c2a0c8445.
---
 src/common/tortls.c |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/common/tortls.c b/src/common/tortls.c
index b4d81de..9ac5c34 100644
--- a/src/common/tortls.c
+++ b/src/common/tortls.c
@@ -585,8 +585,6 @@ tor_tls_create_certificate(crypto_pk_env_t *rsa,
                            const char *cname_sign,
                            unsigned int cert_lifetime)
 {
-  /* OpenSSL generates self-signed certificates with random 64-bit serial
-   * numbers, so let's do that too. */
 #define SERIAL_NUMBER_SIZE 8
 
   time_t start_time, end_time;
@@ -614,12 +612,12 @@ tor_tls_create_certificate(crypto_pk_env_t *rsa,
     goto error;
 
   { /* our serial number is 8 random bytes. */
-    if (crypto_rand((char *)serial_tmp, sizeof(serial_tmp)) < 0)
-      goto error;
-    if (!(serial_number = BN_bin2bn(serial_tmp, sizeof(serial_tmp), NULL)))
-      goto error;
-    if (!(BN_to_ASN1_INTEGER(serial_number, X509_get_serialNumber(x509))))
-      goto error;
+  if (crypto_rand((char *)serial_tmp, sizeof(serial_tmp)) < 0)
+    goto error;
+  if (!(serial_number = BN_bin2bn(serial_tmp, sizeof(serial_tmp), NULL)))
+    goto error;
+  if (!(BN_to_ASN1_INTEGER(serial_number, X509_get_serialNumber(x509))))
+    goto error;
   }
 
   if (!(name = tor_x509_name_new(cname)))



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits