[tor-commits] [tor/master] Address SC2086 in scan-build.sh

[nickm@xxxxxxxxxxxxxx]

commit 59001a69c96a2f14821d312b10482c0854c6d7dd
Author: rl1987 <rl1987@xxxxxxxxxxxxxxxx>
Date:   Mon Nov 26 18:03:36 2018 +0200

    Address SC2086 in scan-build.sh
    
    We can safely silence SC2086 warning on $CHECKERS, as contents of that
    is hardcoded into script, and we don't want to require Bash to use Bash
    array here. Double-quote $OUTPUTARG, as it's value depends on environment
    variable.
---
 scripts/test/scan-build.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/test/scan-build.sh b/scripts/test/scan-build.sh
index e111566bf..9a6338380 100755
--- a/scripts/test/scan-build.sh
+++ b/scripts/test/scan-build.sh
@@ -54,6 +54,7 @@ else
    OUTPUTARG=""
 fi
 
+# shellcheck disable=SC2086
 scan-build \
     $CHECKERS \
     ./configure
@@ -63,13 +64,15 @@ scan-build \
 
 # Make this not get scanned for dead assignments, since it has lots of
 # dead assignments we don't care about.
+# shellcheck disable=SC2086
 scan-build \
     $CHECKERS \
     -disable-checker deadcode.DeadStores \
     make -j5 -k ./src/ext/ed25519/ref10/libed25519_ref10.a
 
+# shellcheck disable=SC2086
 scan-build \
-    $CHECKERS $OUTPUTARG \
+    $CHECKERS "$OUTPUTARG" \
     make -j5 -k
 
 CHECKERS="\



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits