[tor-commits] [snowflake/master] Link to #26360 for why we blackhole logs without -log.

[dcf@xxxxxxxxxxxxxx]

commit a55443937037a8c1f1655aaefc1ca8bb4c0a0f34
Author: David Fifield <david@xxxxxxxxxxxxxxx>
Date:   Tue Dec 18 21:24:32 2018 -0700

    Link to #26360 for why we blackhole logs without -log.
    
    Maybe we'll able to remove this in the far future.
---
 client/snowflake.go | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/client/snowflake.go b/client/snowflake.go
index b2dea5c..006de6b 100644
--- a/client/snowflake.go
+++ b/client/snowflake.go
@@ -93,6 +93,11 @@ func main() {
 		defer logFile.Close()
 		log.SetOutput(logFile)
 	} else {
+		// Don't write to stderr; versions of tor earlier than about
+		// 0.3.5.6 do not read from the pipe, and eventually we will
+		// deadlock because the buffer is full.
+		// https://bugs.torproject.org/26360
+		// https://bugs.torproject.org/25600#comment:14
 		log.SetOutput(ioutil.Discard)
 	}
 

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits