[tor-commits] [tor/main] fix syntax errors listed by cppcheck

[nickm@xxxxxxxxxxxxxx]

commit a86918d524806d34cbcac9c42fc7616ddc4a5fd1
Author: Hans-Christoph Steiner <hans@xxxxxxx>
Date:   Tue Dec 10 22:44:43 2019 +0100

    fix syntax errors listed by cppcheck
---
 src/ext/ed25519/donna/test-ticks.h | 4 ++--
 src/feature/client/entrynodes.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/ext/ed25519/donna/test-ticks.h b/src/ext/ed25519/donna/test-ticks.h
index 0103e03dde..16cec9ba92 100644
--- a/src/ext/ed25519/donna/test-ticks.h
+++ b/src/ext/ed25519/donna/test-ticks.h
@@ -13,7 +13,7 @@ get_ticks(void) {
 		__asm__ __volatile__("rdtsc" : "=a" (lo), "=d" (hi));
 		return ((uint64_t)lo | ((uint64_t)hi << 32));
 	#else
-		need rdtsc for this compiler
+		#error need rdtsc for this compiler
 	#endif
 #elif defined(OS_SOLARIS)
 	return (uint64_t)gethrtime();
@@ -35,7 +35,7 @@ get_ticks(void) {
 	t = ((uint64_t)t2.tv_usec << 32) | (uint64_t)t2.tv_sec;
 	return t;
 #else
-	need ticks for this platform
+	#error need ticks for this platform
 #endif
 }
 
diff --git a/src/feature/client/entrynodes.c b/src/feature/client/entrynodes.c
index 32ecb4f705..15f29d1c3e 100644
--- a/src/feature/client/entrynodes.c
+++ b/src/feature/client/entrynodes.c
@@ -2743,7 +2743,7 @@ entry_guards_upgrade_waiting_circuits(guard_selection_t *gs,
           {NONPRIMARY_GUARD_CONNECT_TIMEOUT} seconds."
     */
     circuit_guard_state_t *state = origin_circuit_get_guard_state(circ);
-    if BUG((state == NULL))
+    if (BUG(state == NULL))
       continue;
     if (state->state != GUARD_CIRC_STATE_COMPLETE)
       continue;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits