[or-cvs] r13388: Remove or downgrade some XXX020 items. (in tor/trunk: . src/or)

[nickm@xxxxxxxx]

Author: nickm
Date: 2008-02-05 16:39:44 -0500 (Tue, 05 Feb 2008)
New Revision: 13388

Modified:
   tor/trunk/
   tor/trunk/src/or/dirvote.c
   tor/trunk/src/or/eventdns.c
   tor/trunk/src/or/eventdns_tor.h
   tor/trunk/src/or/geoip.c
   tor/trunk/src/or/ntmain.c
   tor/trunk/src/or/router.c
Log:
 r17914@catbus:  nickm | 2008-02-05 16:12:16 -0500
 Remove or downgrade some XXX020 items.



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r17914] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/trunk/src/or/dirvote.c
===================================================================
--- tor/trunk/src/or/dirvote.c	2008-02-05 21:39:40 UTC (rev 13387)
+++ tor/trunk/src/or/dirvote.c	2008-02-05 21:39:44 UTC (rev 13388)
@@ -1106,7 +1106,6 @@
  * Certificate functions
  * ===== */
 
-/*XXXX020 make this static? */
 /** Allocate and return a new authority_cert_t with the same contents as
  * <b>cert</b>. */
 authority_cert_t *

Modified: tor/trunk/src/or/eventdns.c
===================================================================
--- tor/trunk/src/or/eventdns.c	2008-02-05 21:39:40 UTC (rev 13387)
+++ tor/trunk/src/or/eventdns.c	2008-02-05 21:39:44 UTC (rev 13388)
@@ -122,7 +122,7 @@
 #include <stdio.h>
 #endif
 
-/*XXXX020 for debugging possible memory leaks. */
+/* for debugging possible memory leaks. */
 #define malloc(x) tor_malloc(x)
 #define realloc(x,y) tor_realloc((x),(y))
 #define free(x) tor_free(x)

Modified: tor/trunk/src/or/eventdns_tor.h
===================================================================
--- tor/trunk/src/or/eventdns_tor.h	2008-02-05 21:39:40 UTC (rev 13387)
+++ tor/trunk/src/or/eventdns_tor.h	2008-02-05 21:39:44 UTC (rev 13388)
@@ -19,7 +19,7 @@
 #define WIN32
 #endif
 
-/* XXXX020 These are for debugging possible memory leaks. */
+/* These are for debugging possible memory leaks. */
 #include "util.h"
 #include "compat.h"
 

Modified: tor/trunk/src/or/geoip.c
===================================================================
--- tor/trunk/src/or/geoip.c	2008-02-05 21:39:40 UTC (rev 13387)
+++ tor/trunk/src/or/geoip.c	2008-02-05 21:39:44 UTC (rev 13388)
@@ -145,7 +145,7 @@
     char buf[512];
     if (fgets(buf, sizeof(buf), f) == NULL)
       break;
-    /* XXXX020 track full country name. */
+    /* FFFF track full country name. */
     geoip_parse_entry(buf);
   }
   /*XXXX020 abort and return -1 if no entries/illformed?*/

Modified: tor/trunk/src/or/ntmain.c
===================================================================
--- tor/trunk/src/or/ntmain.c	2008-02-05 21:39:40 UTC (rev 13387)
+++ tor/trunk/src/or/ntmain.c	2008-02-05 21:39:44 UTC (rev 13388)
@@ -25,8 +25,10 @@
 static SERVICE_STATUS service_status;
 static SERVICE_STATUS_HANDLE hStatus;
 
-/* XXXX020 This 'backup argv' and 'backup argc' business is an ugly hack. This
- * is a job for arguments, not globals. */
+/* XXXX This 'backup argv' and 'backup argc' business is an ugly hack. This
+ * is a job for arguments, not globals.  Alas, some of the functions that
+ * use them use them need to have fixed signatures, so they can be passed
+ * to the NT service functions. */
 static char **backup_argv;
 static int backup_argc;
 static char* nt_strerror(uint32_t errnum);

Modified: tor/trunk/src/or/router.c
===================================================================
--- tor/trunk/src/or/router.c	2008-02-05 21:39:40 UTC (rev 13387)
+++ tor/trunk/src/or/router.c	2008-02-05 21:39:44 UTC (rev 13388)
@@ -261,7 +261,6 @@
 /** Load the v3 (voting) authority signing key and certificate, if they are
  * present.  Return -1 if anything is missing, mismatched, or unloadable;
  * return 0 on success. */
-/* XXXX020 maybe move to dirserv.c or dirvote.c */
 static int
 init_v3_authority_keys(void)
 {