[tor-commits] [tor/maint-0.2.1] Fix a remaining bug in Robert's bug1859 fix.

[nickm@xxxxxxxxxxxxxx]

commit 2392290c1887b732fd2309e57ce04ab71b9b4e69
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Thu Oct 21 11:08:15 2010 -0400

    Fix a remaining bug in Robert's bug1859 fix.
    
    When intro->extend_info is created for an introduction point, it
    only starts out with a nickname, not necessarily an identity digest.
    Thus, doing router_get_by_digest isn't necessarily safe.
---
 src/or/rendclient.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/or/rendclient.c b/src/or/rendclient.c
index ca3f213..1f253c1 100644
--- a/src/or/rendclient.c
+++ b/src/or/rendclient.c
@@ -810,7 +810,10 @@ rend_client_get_random_intro(const rend_data_t *rend_query)
   intro = smartlist_get(entry->parsed->intro_nodes, i);
   /* Do we need to look up the router or is the extend info complete? */
   if (!intro->extend_info->onion_key) {
-    router = router_get_by_digest(intro->extend_info->identity_digest);
+    if (tor_digest_is_zero(intro->extend_info->identity_digest))
+      router = router_get_by_hexdigest(intro->extend_info->nickname);
+    else
+      router = router_get_by_digest(intro->extend_info->identity_digest);
     if (!router) {
       log_info(LD_REND, "Unknown router with nickname '%s'; trying another.",
                intro->extend_info->nickname);



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits