[tor-commits] [tor/master] Fix a null-deref-on-fail in unit tests

[nickm@xxxxxxxxxxxxxx]

commit 9b2bb901d7c306fd6ca28de527e86379470db89a
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Feb 11 16:32:13 2013 -0500

    Fix a null-deref-on-fail in unit tests
    
    If geoip_format_bridge_stats() returned NULL when it should have
    returned a string, we would have tried to deref NULL, and died.  Not
    a big deal in the unit tests, but still worth fixing.
    
    Found by coverity; This is CID 743384.
---
 src/test/test.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/test/test.c b/src/test/test.c
index be0737c..6c64d35 100644
--- a/src/test/test.c
+++ b/src/test/test.c
@@ -1678,6 +1678,7 @@ test_geoip(void)
    * the connecting clients added above. */
   geoip_bridge_stats_init(now);
   s = geoip_format_bridge_stats(now + 86400);
+  test_assert(s);
   test_streq(bridge_stats_1, s);
   tor_free(s);
 

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits