[tor-commits] [tor/master] pass our compiler -fasynchronous-unwind-tables by default

[nickm@xxxxxxxxxxxxxx]

commit 68ed4878ca97902c8b909d88dd855d71e6647376
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Feb 24 11:41:53 2014 -0500

    pass our compiler -fasynchronous-unwind-tables by default
    
    This should make more platforms (in particular, ones with compilers
    where -fomit-frame-pointer is on by default but table generation
    isn't) support backtrace generation.  Thanks to cypherpunks for this
    one.
    
    Fixes bug 11047; bugfix on 0.2.5.2-alpha.
---
 changes/bug11047 |    9 +++++++++
 configure.ac     |    7 +++++++
 2 files changed, 16 insertions(+)

diff --git a/changes/bug11047 b/changes/bug11047
new file mode 100644
index 0000000..25acd8e
--- /dev/null
+++ b/changes/bug11047
@@ -0,0 +1,9 @@
+  o Minor bugfixes:
+
+    - Build using the -fasynchronous-unwind-tables option so that more
+      platforms (in particular, ones like 32-bit Intel where the
+      -fomit-frame-pointer option is on by default and table
+      generation is not) will support generating backtraces. This
+      doesn't yet add Windows support yet; only Linux, OSX, and some BSD
+      are affected. Reported by 'cypherpunks'; fixes bug 11047; bugfix
+      on 0.2.5.2-alpha.
diff --git a/configure.ac b/configure.ac
index 871ca56..187fadc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -649,6 +649,13 @@ CFLAGS="$saved_CFLAGS"
 AC_SUBST(F_OMIT_FRAME_POINTER)
 
 dnl ------------------------------------------------------
+dnl If we are adding -fomit-frame-pointer (or if the compiler's doing it
+dnl for us, as GCC 4.6 and later do at many optimization levels), then
+dnl we should try to add -fasynchronous-unwind-tables so that our backtrace
+dnl code will work.
+TOR_CHECK_CFLAGS(-fasynchronous-unwind-tables)
+
+dnl ------------------------------------------------------
 dnl Where do you live, libnatpmp?  And how do we call you?
 dnl There are no packages for Debian or Redhat as of this patch
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits