[tor-commits] [bridgedb/master] Rip out `BridgeHolder.assignmentsArePersistent()`, it's never used.

[isis@xxxxxxxxxxxxxx]

commit 6206e1f36d94ce1ed3f838a4a16716617772eac7
Author: Isis Lovecruft <isis@xxxxxxxxxxxxxx>
Date:   Wed Jun 11 16:30:51 2014 +0000

    Rip out `BridgeHolder.assignmentsArePersistent()`, it's never used.
    
    Also, for what it's worth: the "proper" way to implement this would have
    been as an @property.
    
     * REMOVE the `assignmentsArePersistent` method from several hashring
       classes in bridgedb.Bridges module.
---
 lib/bridgedb/Bridges.py |   14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/lib/bridgedb/Bridges.py b/lib/bridgedb/Bridges.py
index 50519fb..d159b64 100644
--- a/lib/bridgedb/Bridges.py
+++ b/lib/bridgedb/Bridges.py
@@ -734,12 +734,10 @@ class BridgeHolder(object):
     def clear(self):
         pass
 
-    def assignmentsArePersistent(self):
-        return True
-
     def dumpAssignments(self, f, description=""):
         pass
 
+
 class BridgeRingParameters(object):
     """Store validated settings on minimum number of Bridges with certain
     attributes which should be included in any generated subring of a
@@ -1097,9 +1095,6 @@ class UnallocatedHolder(BridgeHolder):
         if not bridge.fingerprint in self.fingerprints:
             self.fingerprints.append(bridge.fingerprint)
 
-    def assignmentsArePersistent(self):
-        return False
-
     def __len__(self):
         return len(self.fingerprints)
 
@@ -1403,10 +1398,6 @@ class FilteredBridgeSplitter(BridgeHolder):
                     " ".join([v for k,v in grouped.items()]).strip())
             f.write("%s %s\n"%( toHex(b.getID()), desc))
 
-    def assignmentsArePersistent(self):
-        return False
- 
-
 class BridgeBlock(object):
     """Base class that abstracts bridge blocking.
 
@@ -1421,9 +1412,6 @@ class BridgeBlock(object):
     def clear(self):
         pass
 
-    def assignmentsArePersistent(self):
-        return True
-
 class CountryBlock(BridgeBlock):
     """Countrywide bridge blocking"""
     def __init__(self):



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits