[tor-commits] [tor/master] Check for micro < 0, rather than checking "minor" twice.

[nickm@xxxxxxxxxxxxxx]

commit 67cec7578cab40ce43b54d4dfc1370894b91d28f
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri Feb 17 11:31:39 2017 -0500

    Check for micro < 0, rather than checking "minor" twice.
    
    Bug found with clang scan-build.  Fixes bug on f63e06d3dc6757d.
    Bug not present in any released Tor.
---
 src/or/routerparse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index 7d9769b..2ee0d27 100644
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -5551,7 +5551,7 @@ tor_version_parse_platform(const char *platform,
   if (strict) {
     if (router_version->major < 0 ||
         router_version->minor < 0 ||
-        router_version->minor < 0 ||
+        router_version->micro < 0 ||
         router_version->patchlevel < 0 ||
         router_version->svn_revision < 0) {
       return -1;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits