[tor-commits] [Git][tpo/applications/android-components][android-components-96.0.15-11.5-1] 3 commits: Bug 40075: Support scoped storage to enable downloads on API < 29

["Matthew Finkel (@sysrqb)" <gitlab@xxxxxxxxxxxxxx>]

Title: GitLab

Matthew Finkel pushed to branch android-components-96.0.15-11.5-1 at The Tor Project / Applications / android-components

Commits:

• d6444a09
  by aguestuser at 2022-02-18T13:22:07-05:00

  Bug 40075: Support scoped storage to enable downloads on API < 29
  
  - in android-components!7,  we blocked all usage of Scoped
    Storage in an attempt to block usage of Android's
    DownloadManager, which is known to cause proxy bypasses
  - as of Android API 29, downloads will not work without Scoped Storage,
    causing all downlaods to fail (see: fenix##40192)
  - here, we enable usage of scoped storage for API >= 29, but block
    calls to DownloadManager on API < 29
  

• e2daac07
  by aguestuser at 2022-02-18T17:09:02-05:00

  fixup! Bug 40075: Support scoped storage to enable downloads on API < 29
  
  - abandon attempts to block writing file metadata to system db, as
  justified in https://gitlab.torproject.org/tpo/applications/android-components/-/issues/40075#note_2780108
  - this frees us to eliminate the `ANDROID_DOWNLOADS_INTEGRATION` feature toggle altogether
  

• 6ae3342f
  by Matthew Finkel at 2022-02-24T17:26:55+00:00

  Merge remote-tracking branch 'aguestusergl/bug-40075_support-scoped-storage' into android-components-96.0.15-11.5-1
  

2 changed files:

• components/feature/downloads/build.gradle
• components/feature/downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt

Changes:

components/feature/downloads/build.gradle

---

...	...	@@ -21,8 +21,6 @@ android {
21	21	arg("room.schemaLocation", "$projectDir/schemas".toString())
22	22	}
23	23	}
24		-
25		- buildConfigField("boolean", "ANDROID_DOWNLOADS_INTEGRATION", "false")
26	24	}
27	25
28	26	buildTypes {

components/feature/downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt

---

...	...	@@ -371,9 +371,7 @@ abstract class AbstractFetchDownloadService : Service() {
371	371	style.notificationAccentColor
372	372	)
373	373	COMPLETED -> {
374		- if (BuildConfig.ANDROID_DOWNLOADS_INTEGRATION) {
375		- addToDownloadSystemDatabaseCompat(download.state, scope)
376		- }
	374	+ addToDownloadSystemDatabaseCompat(download.state, scope)
377	375	DownloadNotification.createDownloadCompletedNotification(
378	376	context,
379	377	download,
...	...	@@ -841,9 +839,7 @@ abstract class AbstractFetchDownloadService : Service() {
841	839	}
842	840
843	841	@VisibleForTesting
844		- internal fun shouldUseScopedStorage() =
845		- BuildConfig.ANDROID_DOWNLOADS_INTEGRATION &&
846		- getSdkVersion() >= Build.VERSION_CODES.Q
	842	+ internal fun shouldUseScopedStorage() = getSdkVersion() >= Build.VERSION_CODES.Q
847	843
848	844	/**
849	845	* Gets the SDK version from the system.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.torproject.org. If you'd like to receive fewer emails, you can adjust your notification settings.

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits