[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-102.8.0esr-12.0-1] 93 commits: Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame



Title: GitLab

Richard Pospesel pushed to branch tor-browser-102.8.0esr-12.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • afb87585
    by Pier Angelo Vendrame at 2023-02-08T13:50:14+00:00
    Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
    
    Bundled fonts were not picked up because also child processes need to
    register them.
    Also, they were assigned User visibility, instead of Base, which was
    not coherent with other platforms.
    
    Differential Revision: https://phabricator.services.mozilla.com/D150400
  • 2c225a70
    by Pier Angelo Vendrame at 2023-02-08T13:50:14+00:00
    Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium
    
    Add a configuration flag to make Enterprise Policies mechanism only
    consult a policies.json file (avoiding the Windows Registry, macOS's
    file system attributes, and /etc/firefox/policies/policies.json on
    other OS).
    
    Differential Revision: https://phabricator.services.mozilla.com/D146300
    
  • 35877fe2
    by Jamie Nicol at 2023-02-08T13:50:14+00:00
    Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond
    
    Differential Revision: https://phabricator.services.mozilla.com/D154897
  • 26152089
    by Pier Angelo Vendrame at 2023-02-08T13:50:14+00:00
    Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers
    
    Differential Revision: https://phabricator.services.mozilla.com/D157843
    
  • 3dc56306
    by Neill Miller at 2023-02-08T13:50:15+00:00
    Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman
    
    nsTransferable was modified to prevent disk leakings when copying data
    in private browsing mode with Bug 1123480.
    However, the context is nullptr when it is initialized, so it still
    leaks if PBM is enabled by default.
    Our solution is to check the browser.privatebrowsing.autostart in this
    condition.
    
    Differential Revision: https://phabricator.services.mozilla.com/D157800
  • 98f783e2
    by Gabriele Svelto at 2023-02-08T13:50:15+00:00
    Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium
    
    macOS unfair locks enforce that a lock can only be released by the thread which locked it.
    
    On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.
    
    Differential Revision: https://phabricator.services.mozilla.com/D148287
  • 890d9731
    by Gabriele Svelto at 2023-02-08T13:50:15+00:00
    Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium
    
    Depends on D148287
    
    Differential Revision: https://phabricator.services.mozilla.com/D99280
  • 8d63a5b9
    by Gabriele Svelto at 2023-02-08T13:50:16+00:00
    Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone
    
    Differential Revision: https://phabricator.services.mozilla.com/D149599
  • 67924adc
    by Gabriele Svelto at 2023-02-08T13:50:16+00:00
    Bug 1784018 - Remove deprecated OSSpinLocks r=glandium
    
    On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space
    which degrades performance significantly. To obviate for this we spin in
    user-space like OSSpinLock does, for the same number of times and invoking
    x86-specific pause instructions in-between the locking attempts to avoid
    starving a thread that might be running on the same physical core.
    
    Differential Revision: https://phabricator.services.mozilla.com/D154205
  • 95cd88aa
    by Georg Koppen at 2023-02-08T13:50:16+00:00
    Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"
    
    This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.
    
    This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706.
    However, it is a temporary workaround, that we should revert once
    https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.
    
  • 8747fce6
    by Richard Pospesel at 2023-02-08T13:50:17+00:00
    fixup! Bug 1761389 - Add and use new PDF-specific document icon on Windows. r=bhearsum
    
  • 6db4b54e
    by Henry Wilkes at 2023-02-08T13:50:40+00:00
    Bug 41454: Move focus after calling openPreferences for a sub-category.
    
    Temporary fix until mozilla bug 1799153 gets a patch upstream.
    
  • 150b5171
    by Pier Angelo Vendrame at 2023-02-09T14:09:10+00:00
    Bug 41116: Normalize system fonts.
    
    System fonts are an enormous fingerprinting vector.
    Even with font allow lists and with our custom configuration on Linux,
    which counter metrics measurements, getComputedStyle leaks several
    details.
    This patch counters both these kinds of attacks.
    
  • 7a872d5e
    by Pier Angelo Vendrame at 2023-02-09T14:09:10+00:00
    Tweaks to the build system
    
    Bug 40857: Modified the fat .aar creation file
    
    This is a workaround to build fat .aars with the compiling enviornment
    disabled.
    Mozilla does not use a similar configuration, but either runs a Firefox
    build and discards its output, or uses artifacts build.
    
    We might switch to artifact builds too, and drop this patch, or write a
    better one to upstream. But until then we need this patch.
    
    See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.
    
    Bug 41458: Prevent `mach package-multi-locale` from actually creating a package
    
    macOS builds need some files to be moved around with
    ./mach package-multi-locale to create multi-locale packages.
    The required command isn't exposed through any other mach command.
    So, we patch package-multi-locale both to prevent it from failing when
    doing official builds and to detect any future changes on it.
    
  • 5643c993
    by Dan Ballard at 2023-02-09T14:09:10+00:00
    Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restpre email link on mac
    
  • 673e2078
    by Gaba at 2023-02-09T14:09:11+00:00
    Adding issue template for bugs.
    
  • 9b800046
    by Pier Angelo Vendrame at 2023-02-09T14:09:11+00:00
    Base Browser's .mozconfigs.
    
  • a7f1e3dc
    by Pier Angelo Vendrame at 2023-02-09T14:09:11+00:00
    Bug 41108: Remove privileged macOS installation from 102
    
  • 7cd0ca00
    by Dan Ballard at 2023-02-09T14:09:12+00:00
    Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
    
  • ada9b1e3
    by Matthew Finkel at 2023-02-09T14:09:12+00:00
    Bug 24796: Comment out excess permissions from GeckoView
    
    The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
    manifest, so we can't use the ifdef preprocessor guards around the
    permissions we do not want. Commenting the permissions is the
    next-best-thing.
    
  • aa280445
    by Matthew Finkel at 2023-02-09T14:09:12+00:00
    Bug 25741: TBA: Disable GeckoNetworkManager
    
    The browser should not need information related to the network
    interface or network state, tor should take care of that.
    
  • 75543a65
    by Matthew Finkel at 2023-02-09T14:09:13+00:00
    Bug 28125: Prevent non-Necko network connections
    
  • 3bf84f4c
    by Mike Perry at 2023-02-09T14:09:13+00:00
    Bug 12974: Disable NTLM and Negotiate HTTP Auth
    
    The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421,
    https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602
    
  • 5cfb5257
    by Alex Catarineu at 2023-02-09T14:09:13+00:00
    Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots
    
    Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899
    
  • ef5e63c9
    by Georg Koppen at 2023-02-09T14:09:14+00:00
    Bug 16285: Exclude ClearKey system for now
    
    In the past the ClearKey system had not been compiled when specifying
    --disable-eme. But that changed and it is even bundled nowadays (see:
    Mozilla's bug 1300654). We don't want to ship it right now as the use
    case for it is not really visible while the code had security
    vulnerabilities in the past.
    
  • 741f6c8b
    by Kathy Brade at 2023-02-09T14:09:14+00:00
    Bug 21431: Clean-up system extensions shipped in Firefox
    
    Only ship the pdfjs extension.
    
  • 18813801
    by Kathy Brade at 2023-02-09T14:09:14+00:00
    Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.
    
    Hide elements on about:logins that mention sync, "Firefox LockWise", and
    Mozilla's LockWise mobile apps.
    
    Disable the "Create New Login" button when security.nocertdb is true.
    
  • d87d59a3
    by Alex Catarineu at 2023-02-09T14:09:15+00:00
    Bug 41457: Remove Mozilla permissions
    
    Bug 40025: Remove Mozilla add-on install permissions
    
  • ba4a31ec
    by Kathy Brade at 2023-02-09T14:09:15+00:00
    Bug 40002: Remove about:ion
    
    Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people
    volunteer to participate in studies that collect detailed, sensitive data about
    how they use their browser.
    
  • 17645ecf
    by Arthur Edelstein at 2023-02-09T14:09:15+00:00
    Bug 26353: Prevent speculative connect that violated FPI.
    
    Connections were observed in the catch-all circuit when
    the user entered an https or http URL in the URL bar, or
    typed a search term.
    
  • f19824d5
    by Alex Catarineu at 2023-02-09T14:09:15+00:00
    Bug 31740: Remove some unnecessary RemoteSettings instances
    
    More concretely, SearchService.jsm 'hijack-blocklists' and
    url-classifier-skip-urls.
    
    Avoid creating instance for 'anti-tracking-url-decoration'.
    
    If prefs are disabling their usage, avoid creating instances for
    'cert-revocations' and 'intermediates'.
    
    Do not ship JSON dumps for collections we do not expect to need. For
    the ones in the 'main' bucket, this prevents them from being synced
    unnecessarily (the code in remote-settings does so for collections
    in the main bucket for which a dump or local data exists). For the
    collections in the other buckets, we just save some size by not
    shipping their dumps.
    
    We also clear the collections database on the v2 -> v3 migration.
    
  • d98f0954
    by Georg Koppen at 2023-02-09T14:09:16+00:00
    Bug 30541: Disable WebGL readPixel() for web content
    
    Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034
    
  • c215f756
    by Alex Catarineu at 2023-02-09T14:09:16+00:00
    Bug 28369: Stop shipping pingsender executable
    
  • ae61963b
    by Alex Catarineu at 2023-02-09T14:09:16+00:00
    Bug 40073: Disable remote Public Suffix List fetching
    
    In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
    fetching the Public Suffix List via RemoteSettings and replacing the default
    one at runtime, which we do not want.
    
  • 8b1665cf
    by Mike Perry at 2023-02-09T14:09:17+00:00
    Firefox preference overrides.
    
    This hack directly includes our preference changes in omni.ja.
    
    Bug 18292: Staged updates fail on Windows
    
    Temporarily disable staged updates on Windows.
    
    Bug 18297: Use separate Noto JP,KR,SC,TC fonts
    
    Bug 23404: Add Noto Sans Buginese to the macOS whitelist
    
    Bug 23745: Set dom.indexedDB.enabled = true
    
    Bug 13575: Disable randomised Firefox HTTP cache decay user tests.
    (Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx>)
    
    Bug 17252: Enable session identifiers with FPI
    
    Session tickets and session identifiers were isolated
    by OriginAttributes, so we can re-enable them by
    allowing the default value (true) of
    "security.ssl.disable_session_identifiers".
    
    The pref "security.enable_tls_session_tickets" is obsolete
    (removed in https://bugzilla.mozilla.org/917049)
    
    Bug 14952: Enable http/2 and AltSvc
    
    In Firefox, SPDY/HTTP2 now uses Origin Attributes for
    isolation of connections, push streams, origin frames, etc.
    That means we get first-party isolation provided
    "privacy.firstparty.isolate" is true. So in this patch, we
    stop overriding "network.http.spdy.enabled" and
    "network.http.spdy.enabled.http2".
    
    Alternate Services also use Origin Attributes for isolation.
    So we stop overriding
    "network.http.altsvc.enabled" and "network.http.altsvc.oe"
    as well.
    
    (All 4 of the abovementioned "network.http.*" prefs adopt
    Firefox 60ESR's default value of true.)
    
    However, we want to disable HTTP/2 push for now, so we
    set "network.http.spdy.allow-push" to false.
    
    "network.http.spdy.enabled.http2draft" was removed in Bug 1132357.
    "network.http.sped.enabled.v2" was removed in Bug 912550.
    "network.http.sped.enabled.v3" was removed in Bug 1097944.
    "network.http.sped.enabled.v3-1" was removed in Bug 1248197.
    
    Bug 26114: addons.mozilla.org is not special
    * Don't expose navigator.mozAddonManager on any site
    * Don't block NoScript from modifying addons.mozilla.org or other sites
    
    Enable ReaderView mode again (#27281).
    
    Bug 29916: Make sure enterprise policies are disabled
    
    Bug 2874: Block Components.interfaces from content
    
    Bug 26146: Spoof HTTP User-Agent header for desktop platforms
    
    In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent
    header and to _javascript_ code via navigator.userAgent. To avoid
    leaking the OS inside each HTTP request (which many web servers
    log), always use the Windows 7 OS value in the desktop User-Agent
    header. We continue to allow access to the actual OS via _javascript_,
    since doing so improves compatibility with web applications such
    as GitHub and Google Docs.
    
    Bug 12885: Windows Jump Lists fail for Tor Browser
    
    Jumplist entries are stored in a binary file in:
      %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\
    and has a name in the form
      [a-f0-9]+.customDestinations-ms
    
    The hex at the front is unique per app, and is ultimately derived from
    something called the 'App User Model ID' (AUMID) via some unknown
    hashing method. The AUMID is provided as a key when programmatically
    creating, updating, and deleting a jumplist. The default behaviour in
    firefox is for the installer to define an AUMID for an app, and save it
    in the registry so that the jumplist data can be removed by the
    uninstaller.
    
    However, the Tor Browser does not set this (or any other) regkey during
    installation, so this codepath fails and the app's AUMID is left
    undefined. As a result the app's AUMID ends up being defined by
    windows, but unknowable by Tor Browser. This unknown AUMID is used to
    create and modify the jumplist, but the delete API requires that we
    provide the app's AUMID explicitly. Since we don't know what the AUMID
    is (since the expected regkey where it is normally stored does not
    exist) jumplist deletion will fail and we will leave behind a mostly
    empty customDestinations-ms file. The name of the file is derived from
    the binary path, so an enterprising person could reverse engineer how
    that hex name is calculated, and generate the name for Tor Browser's
    default Desktop installation path to determine whether a person had
    used Tor Browser in the past.
    
    The 'taskbar.grouping.useprofile' option that is enabled by this patch
    works around this AUMID problem by having firefox.exe create it's own
    AUMID based on the profile path (rather than looking for a regkey). This
    way, if a user goes in and enables and disables jumplist entries, the
    backing store is properly deleted.
    
    Unfortunately, all windows users currently have this file lurking in
    the above mentioned directory and this patch will not remove it since it
    was created with an unknown AUMID. However, another patch could be
    written which goes to that directory and deletes any item containing the
    'Tor Browser' string.  See bug 28996.
    
    Bug 30845: Make sure default themes and other internal extensions are enabled
    
    Bug 28896: Enable extensions in private browsing by default
    
    Bug 31065: Explicitly allow proxying localhost
    
    Bug 31598: Enable letterboxing
    
    Disable Presentation API everywhere
    
    Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer
    security levels.
    
    Bug 32321: Disable Mozilla's MitM pings
    
    Bug 19890: Disable installation of system addons
    
    By setting the URL to "" we make sure that already installed system
    addons get deleted as well.
    
    Bug 22548: Firefox downgrades VP9 videos to VP8.
    
    On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor
    Browser 7.0 all youtube videos are degraded to VP8.
    
    This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0.
    All clients will get better experience and lower traffic, beause TBB doesn't
    use "Use hardware acceleration when available".
    
    Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
    
    Bug 16441: Suppress "Reset Tor Browser" prompt.
    
    Bug 29120: Use the in-memory media cache and increase its maximum size.
    
    Bug 33697: use old search config based on list.json
    
    Bug 33855: Ensure that site-specific browser mode is disabled.
    
    Bug 30682: Disable Intermediate CA Preloading.
    
    Bug 40061: Omit the Windows default browser agent from the build
    
    Bug 40322: Consider disabling network.connectivity-service.enabled
    
    Bug 40408: Disallow SVG Context Paint in all web content
    
    Bug 40308: Disable network partitioning until we evaluate dFPI
    
    Bug 40322: Consider disabling network.connectivity-service.enabled
    
    Bug 40383: Disable dom.enable_event_timing
    
    Bug 40423: Disable http/3
    
    Bug 40177: Update prefs for Fx91esr
    
    Bug 40700: Disable addons and features recommendations
    
    Bug 40682: Disable network.proxy.allow_bypass
    
    Bug 40736: Disable third-party cookies in PBM
    
    Bug 19850: Enabled HTTPS-Only by default
    
    Bug 40912: Hide the screenshot menu
    
    Bug 41292: Disable moreFromMozilla in preferences page
    
    Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector
    
    Bug 24686: Set network.http.tailing.enabled to true
    
    Bug 40183: Disable TLS ciphersuites using SHA-1
    
    Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102
    
    We reviewed all the preferences we set for 102, and remove a few old
    ones. See the description of that issue to see all the preferences we
    believed were still valid for 102, and some brief description for the
    reasons to keep them.
    
  • 0a1eb4eb
    by Pier Angelo Vendrame at 2023-02-09T14:09:17+00:00
    Bug 41043: Hardcode the UI font on Linux
    
    The mechanism to choose the UI font does not play well with our
    fontconfig configuration. As a result, the final criterion to choose
    the font for the UI was its version.
    
    Since we hardcode Arimo as a default sans-serif on preferences, we use
    it also for the UI. FontConfig will fall back to some other font for
    scripts Arimo does not cover as expected (we tested with Japanese).
    
  • 0795a034
    by Alex Catarineu at 2023-02-09T14:09:17+00:00
    Bug 30605: Honor privacy.spoof_english in Android
    
    This checks `privacy.spoof_english` whenever `setLocales` is
    called from Fenix side and sets `intl.accept_languages`
    accordingly.
    
    Bug 40198: Expose privacy.spoof_english pref in GeckoView
    
  • 4a11f33d
    by Alex Catarineu at 2023-02-09T14:09:18+00:00
    Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView
    
  • e13dbb5b
    by Alex Catarineu at 2023-02-09T14:09:18+00:00
    Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware
    
  • c4e9ed0e
    by Alex Catarineu at 2023-02-09T14:09:18+00:00
    Bug 26345: Hide tracking protection UI
    
  • 1eb58fd6
    by Kathy Brade at 2023-02-09T14:09:19+00:00
    Bug 9173: Change the default Firefox profile directory to be relative.
    
    This should eliminate our need to rely on a wrapper script that
    sets /Users/arthur and launches Firefox with -profile.
    
  • 6af56335
    by Kathy Brade at 2023-02-09T14:09:19+00:00
    Bug 18800: Remove localhost DNS lookup in nsProfileLock.cpp
    
    Instead of using the local computer's IP address within
    symlink-based profile lock signatures, always use 127.0.0.1.
    
    Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1769028
    
  • 81e436a2
    by Alex Catarineu at 2023-02-09T14:09:19+00:00
    Bug 27604: Fix addon issues when moving the profile directory
    
    Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838
    
  • 125278ea
    by Mike Perry at 2023-02-09T14:09:20+00:00
    Bug 13028: Prevent potential proxy bypass cases.
    
    It looks like these cases should only be invoked in the NSS command line
    tools, and not the browser, but I decided to patch them anyway because there
    literally is a maze of network function pointers being passed around, and it's
    very hard to tell if some random code might not pass in the proper proxied
    versions of the networking code here by accident.
    
    Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509
    
  • 8b0252eb
    by Kathy Brade at 2023-02-09T14:09:20+00:00
    Bug 11641: Disable remoting by default.
    
    Unless the -osint command line flag is used, the browser now defaults
    to the equivalent of -no-remote.  There is a new -allow-remote flag that
    may be used to restore the original (Firefox-like) default behavior.
    
  • 76b9ea1d
    by Igor Oliveira at 2023-02-09T14:09:20+00:00
    Bug 23104: Add a default line height compensation
    
    Many fonts have issues with their vertical metrics. they
    are used to influence the height of ascenders and depth
    of descenders. Gecko uses it to calculate the line height
    (font height + ascender + descender), however because of
    that idiosyncratic behavior across multiple operating
    systems, it can be used to identify the user's OS.
    
    The solution proposed in the patch uses a default factor
    to be multiplied with the font size, simulating the concept
    of ascender and descender. This way all operating
    systems will have the same line height only and only if the
    frame is outside the chrome.
    
  • 644e8179
    by Pier Angelo Vendrame at 2023-02-09T14:09:21+00:00
    Bug 40309: Avoid using regional OS locales
    
    Avoid regional OS locales if the pref
    `intl.regional_prefs.use_os_locales` is false but RFP is enabled.
    
  • 2e6db28b
    by Matthew Finkel at 2023-02-09T14:09:21+00:00
    Bug 40432: Prevent probing installed applications
    
    Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084
    
  • 67d701c3
    by hackademix at 2023-02-09T14:09:22+00:00
    Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
    
  • d1de70f7
    by hackademix at 2023-02-09T14:09:22+00:00
    Bug 41434: Letterboxing, improve logging.
    
  • 576947f1
    by hackademix at 2023-02-09T14:09:22+00:00
    Bug 31064: Letterboxing, exempt browser extensions.
    
  • c836fca2
    by hackademix at 2023-02-09T14:09:23+00:00
    Bug 32411: Letterboxing, exempt view-source: URIs.
    
  • c8a4fe01
    by Richard Pospesel at 2023-02-09T14:09:23+00:00
    Bug 32220: Improve the letterboxing experience
    
    CSS and JS changes to alter the UX surrounding letterboxing. The
    browser element containing page content is now anchored to the bottom
    of the toolbar, and the remaining letterbox margin is the same color
    as the firefox chrome. The letterbox margin and outline are tied to
    the currently selected theme.
    
    Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1594455
    
  • ddd4aff5
    by Alex Catarineu at 2023-02-09T14:09:24+00:00
    Bug 40069: Add helpers for message passing with extensions
    
  • 8b5ef8db
    by Matthew Finkel at 2023-02-09T14:09:24+00:00
    Bug 40253: Explicitly allow NoScript in Private Browsing mode.
    
  • afabeab9
    by Pier Angelo Vendrame at 2023-02-09T14:09:24+00:00
    Bug 41369: Improve Firefox language settings for multi-lingual packages
    
    Change the language selector to be sorted by language code, rather than
    name, and to display the language code to the user.
    
    Bug 41372: Handle Japanese as a special case in preferences on macOS
    
    Japanese is treated in a special way on macOS. However, seeing the
    Japanese language tag could be confusing for users, and moreover the
    language name is not localized correctly like other langs.
    
    Bug 41378: Tell users that they can change their language at the first start
    
    With multi-lingual builds, Tor Browser matches the user's system
    language, but some users might want to change it.
    So, we tell them that it is possible, but only once.
    
  • d5624033
    by Henry Wilkes at 2023-02-09T14:09:25+00:00
    Bug 41371: Temporary hack to fix language selector popup position
    
  • 03cbdc38
    by Pier Angelo Vendrame at 2023-02-09T14:09:25+00:00
    Bug 41417: Always prompt users to restart after changing language
    
    This is a temporary patch that we need until we switch our strings to
    Fluent. The reason is that we currently set strings when we populate
    our XUL content.
    We could rework the whole mechanism, but it is not worth it because we
    want to switch to Fluent, which will handle everything automatically.
    
  • 7ca8d9b9
    by Pier Angelo Vendrame at 2023-02-09T14:09:25+00:00
    Bug 40925: Implemented the Security Level component
    
    This component adds a new Security Level toolbar button which visually
    indicates the current global security level via icon (as defined by the
    extensions.torbutton.security_slider pref), a drop-down hanger with a
    short description of the current security level, and a new section in
    the about:preferences#privacy page where users can change their current
    security level. In addition, the hanger and the preferences page will
    show a visual warning when the user has modified prefs associated with
    the security level and provide a one-click 'Restore Defaults' button to
    get the user back on recommended settings.
    
    Bug 40125: Expose Security Level pref in GeckoView
    
  • f90d9640
    by Pier Angelo Vendrame at 2023-02-09T14:09:26+00:00
    Bug 40926: Implemented the New Identity feature
    
  • 7194e92f
    by Richard Pospesel at 2023-02-09T14:09:26+00:00
    Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
    
  • 78b5b3e0
    by Mike Perry at 2023-02-09T14:09:26+00:00
    Bug 2176: Rebrand Firefox to TorBrowser
    
    See also Bugs #5194, #7187, #8115, #8219.
    
    This patch does some basic renaming of Firefox to TorBrowser. The rest of the
    branding is done by images and icons.
    
    Also fix bug 27905.
    
    Bug 25702: Update Tor Browser icon to follow design guidelines
    
    - Updated all of the branding in /browser/branding/official with new 'stable'
    icon series.
    - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
    add the source svg in the same directory
    - Copied /browser/branding/official over /browser/branding/nightly and the new
    /browser/branding/alpha directories. Replaced content with 'nightly' and
    'alpha' icon series.
    Updated VisualElements_70.png and VisualElements_150.png with updated icons in
    each branding directory (fixes #22654)
    - Updated firefox.VisualElementsManfiest.xml with updated colors in each
    branding directory
    - Added firefox.svg to each branding directory from which all the other icons
    are derived (apart from document.icns and document.ico)
    - Added default256.png and default512.png icons
    - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
    original icon
    - Use the Tor Browser icon within devtools/client/themes/images/.
    
    Bug 30631: Blurry Tor Browser icon on macOS app switcher
    
    It would seem the png2icns tool does not generate correct icns files and
    so on macOS the larger icons were missing resulting in blurry icons in
    the OS chrome. Regenerated the padded icons in a macOS VM using
    iconutil.
    
    Bug 28196: preparations for using torbutton tor-browser-brand.ftl
    
    A small change to Fluent FileSource class is required so that we
    can register a new source without its supported locales being
    counted as available locales for the browser.
    
    Bug 31803: Replaced about:debugging logo with flat version
    
    Bug 21724: Make Firefox and Tor Browser distinct macOS apps
    
    When macOS opens a document or selects a default browser, it sometimes
    uses the CFBundleSignature. Changing from the Firefox MOZB signature to
    a different signature TORB allows macOS to distinguish between Firefox
    and Tor Browser.
    
    Bug 32092: Fix Tor Browser Support link in preferences
    
    For bug 40562, we moved onionPattern* from bug 27476 to here, as
    about:tor needs these files but it is included earlier.
    
    Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one
    
  • e5e05f86
    by Alex Catarineu at 2023-02-09T14:09:27+00:00
    Bring back old Firefox onboarding
    
    Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
    
    This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432.
    
    Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
    
    This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2.
    
    Bug 28822: Convert onboarding to webextension
    
    Partially revert 1564367 (controlCenter in UITour.jsm)
    
  • 11b2f5a4
    by Kathy Brade at 2023-02-09T14:09:27+00:00
    Bug 26961: New user onboarding.
    
    Reuse the Firefox onboarding mechanism with minimal changes.
    Localizable strings are pulled in from Torbutton (if Torbutton is
      not installed, we lack about:tor and no tour will be shown).
    Replace SVG images with PNGs (see bug 27002),
    For defense in depth, omit include OnboardingTelemetry.jsm entirely.
    Added support for the following UITour page event:
      torBrowserOpenSecuritySettings
    
    Also fix bug 27403: the onboarding bubble is not always displayed.
    
    Arthur suggested to make the onboarding bubble visible on displays with
    less than 960px width available, so we choose 200px instead.
    
    Also fix bug 28628: Change onboarding Security panel to open new
    Security Level panel.
    
    Also fix bug 27484: Improve navigation within onboarding.
    
    Bug 27082: enable a limited UITour
    
    Disallow access to UITour functionality from all pages other than
      about:home, about:newtab, and about:tor.
    Implement a whitelist mechanism for page actions.
    
    Bug 26962 - implement new features onboarding (part 1).
    
    Add an "Explore" button to the "Circuit Display" panel within new user
    onboarding which opens the DuckDuckGo .onion and then guides users through
    a short circuit display tutorial.
    
    Allow a few additional UITour actions while limiting as much as possible
    how it can be used.
    
    Tweak the UITour styles to match the Tor Browser branding.
    
    All user interface strings are retrieved from Torbutton's
    browserOnboarding.properties file.
    
    Bug 27486 Avoid about:blank tabs when opening onboarding pages.
    
    Instead of using a simple <a href>, programmatically open onboarding
    web pages by using tabBrowser.addTab(). The same technique is now
    used for "See My Path", "See FAQs", and "Visit an Onion".
    
    Bug 29768: Introduce new features to users
    
    Add an "update" tour for the Tor Browser 8.5 release that contains two
    panels: Toolbar and Security (with appropriate description text and
    images).
    
    Display an attention-grabbing dot on the onboarding text bubble when
    the update tour is active. The animation lasts for 14 seconds.
    
    Bug 31768: Introduce toolbar and network settings changes in onboarding
    
    Update the "Tor Network" onboarding page to include a note that
    settings can now be accessed via the application preferences and
    add an "Adjust Your Tor Network Settings" action button which opens
    about:preferences#tor.
    
    Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one
    that includes the revised "Tor Network" page and a revised "Toolbar"
    page. The latter explains that Torbutton's toolbar item has been
    removed ("Goodbye Onion Button") and explains how to access the
    New Identity feature using the hamburger menu and new toolbar item.
    
    Bug 34321 - Add Learn More onboarding item
    
    Bug 40429: Update Onboarding for 10.5
    
  • 1e8f6720
    by Mike Perry at 2023-02-09T14:09:27+00:00
    TB3: Tor Browser's official .mozconfigs.
    
    Also:
    Bug #9829.1: new .mozconfig file for the new cross-compiler and ESR24
    Changes needed to build Mac in 64bit
    Bug 10715: Enable Webgl for mingw-w64 again.
    Disable ICU when cross-compiling; clean-up.
    Bug 15773: Enable ICU on OS X
    Bug 15990: Don't build the sandbox with mingw-w64
    Bug 12761: Switch to ESR 38 for OS X
    Updating .mozconfig-asan
    Bug 12516: Compile hardenend Tor Browser with -fwrapv
    Bug 18331: Switch to Mozilla's toolchain for building Tor Browser for OS X
    Bug 17858: Cannot create incremental MARs for hardened builds.
    Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff
    (which is part of mar-tools and is not distributed to end-users) with
    ASan.
    Bug 13419: Add back ICU for Windows
    Bug 21239: Use GTK2 for ESR52 Linux builds
    Bug 23025: Add hardening flags for macOS
    Bug 24478: Enable debug assertions and tests in our ASan builds
    --enable-proxy-bypass-protection
    Bug 27597: ASan build option in tor-browser-build is broken
    
    Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
    
    This fixes a problem where some preferences had the wrong default value.
    Also see bug 27472 where we made a similar fix for Android.
    
    Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
    
    Bug 31450: Set proper BINDGEN_CFLAGS for ASan builds
    
    Add an --enable-tor-browser-data-outside-app-dir configure option
    
    Add --with-tor-browser-version configure option
    
    Bug 21849: Don't allow SSL key logging.
    
    Bug 31457: disable per-installation profiles
    
    The dedicated profiles (per-installation) feature does not interact
    well with our bundled profiles on Linux and Windows, and it also causes
    multiple profiles to be created on macOS under TorBrowser-Data.
    
    Bug 31935: Disable profile downgrade protection.
    
    Since Tor Browser does not support more than one profile, disable
    the prompt and associated code that offers to create one when a
    version downgrade situation is detected.
    
    Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT
    
    Bug 25741 - TBA: Disable features at compile-time
    
    MOZ_NATIVE_DEVICES for casting and the media player
    MOZ_TELEMETRY_REPORTING for telemetry
    MOZ_DATA_REPORTING for all data reporting preferences (crashreport, telemetry, geo)
    
    Bug 25741 - TBA: Add default configure options in dedicated file
    
    Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
    
    Bug 29859: Disable HLS support for now
    
    Add --disable-tor-launcher build option
    
    Add --enable-tor-browser-update build option
    
    Bug 33734: Set MOZ_NORMANDY to False
    
    Bug 33851: Omit Parental Controls.
    
    Bug 40061: Omit the Windows default browser agent from the build
    
    Bug 40107: Adapt .mozconfig-asan for ESR 78
    
    Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files
    
    Bug 40793: moved Tor configuration options from old-configure.in to moz.configure
    
  • f1f986e2
    by Henry Wilkes at 2023-02-09T14:09:28+00:00
    Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds
    
    tor-browser#41285: Enable fluent warnings.
    
  • 70c1a71e
    by Pier Angelo Vendrame at 2023-02-09T14:09:28+00:00
    Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
    
    Before reordering patches, we used to keep the Tor-related patches
    (torbutton and tor-launcher) at the beginning.
    After that issue, we decided to move them towards the end.
    
    In addition to that, we have decided to move Tor Browser-only
    preferences there, too, to make Base Browser-only fixups easier to
    apply.
    
  • fd5cb70e
    by Kathy Brade at 2023-02-09T14:09:28+00:00
    Bug 13252: Do not store data in the app bundle
    
    When --enable-tor-browser-data-outside-app-dir is enabled,
    all user data is stored in a directory named
    TorBrowser-Data which is located next to the application directory.
    
    Display an informative error message if the TorBrowser-Data
    directory cannot be created due to an "access denied" or a
    "read only volume" error.
    
    On Mac OS, add support for the --invisible command line option which
    is used by the meek-http-helper to avoid showing an icon for the
    helper browser on the dock.
    
  • b5babfee
    by Pier Angelo Vendrame at 2023-02-09T14:09:29+00:00
    Bug 40933: Add tor-launcher functionality
    
  • de99682d
    by Richard Pospesel at 2023-02-09T14:09:29+00:00
    Bug 40597: Implement TorSettings module
    
    - migrated in-page settings read/write implementation from about:preferences#tor
      to the TorSettings module
    - TorSettings initially loads settings from the tor daemon, and saves them to
      firefox prefs
    - TorSettings notifies observers when a setting has changed; currently only
      QuickStart notification is implemented for parity with previous preference
      notify logic in about:torconnect and about:preferences#tor
    - about:preferences#tor, and about:torconnect now read and write settings
      thorugh the TorSettings module
    - all tor settings live in the torbrowser.settings.* preference branch
    - removed unused pref modify permission for about:torconnect content page from
      AsyncPrefs.jsm
    
    Bug 40645: Migrate Moat APIs to Moat.jsm module
    
  • fc894e21
    by Alex Catarineu at 2023-02-09T14:09:30+00:00
    Bug 10760: Integrate TorButton to TorBrowser core
    
    Because of the non-restartless nature of Torbutton, it required
    a two-stage installation process. On mobile, it was a problem,
    because it was not loading when the user opened the browser for
    the first time.
    
    Moving it to tor-browser and making it a system extension allows it
    to load when the user opens the browser for first time.
    
    Additionally, this patch also fixes Bug 27611.
    
    Bug 26321: New Circuit and New Identity menu items
    
    Bug 14392: Make about:tor behave like other initial pages.
    
    Bug 25013: Add torbutton as a tor-browser submodule
    
    Bug 31575: Replace Firefox Home (newtab) with about:tor
    
    Avoid loading AboutNewTab in BrowserGlue.jsm in order
    to avoid several network requests that we do not need. Besides,
    about:newtab will now point to about:blank or about:tor (depending
    on browser.newtabpage.enabled) and about:home will point to
    about:tor.
    
  • 0795c1f4
    by hackademix at 2023-02-09T14:09:30+00:00
    Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop
    
  • 0a59ce83
    by Amogh Pradeep at 2023-02-09T14:09:30+00:00
    Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.
    
    See Bug 1357997 for partial uplift.
    
    Also:
    Bug 28051 - Use our Orbot for proxying our connections
    
    Bug 31144 - ESR68 Network Code Review
    
  • 7944c269
    by Alex Catarineu at 2023-02-09T14:09:31+00:00
    Add TorStrings module for localization
    
  • 767365ab
    by Kathy Brade at 2023-02-09T14:09:31+00:00
    Bug 14631: Improve profile access error messages.
    
    Instead of always reporting that the profile is locked, display specific
    messages for "access denied" and "read-only file system".
    
    To allow for localization, get profile-related error strings from Torbutton.
    Use app display name ("Tor Browser") in profile-related error alerts.
    
  • cfb3d1e4
    by sanketh at 2023-02-09T14:09:31+00:00
    Bug 40209: Implement Basic Crypto Safety
    
    Adds a CryptoSafety actor which detects when you've copied a crypto
    address from a HTTP webpage and shows a warning.
    
    Closes #40209.
    
    Bug 40428: Fix string attribute names
    
  • c6a86885
    by Kathy Brade at 2023-02-09T14:09:32+00:00
    Bug 19273: Avoid _javascript_ patching of the external app helper dialog.
    
    When handling an external URI or downloading a file, invoke Torbutton's
    external app blocker component (which will present a download warning
    dialog unless the user has checked the "Automatically download files
    from now on" box).
    
    For e10s compatibility, avoid using a modal dialog and instead use
    a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton
    to indicate the user's desire to cancel or continue each request.
    
    Other bugs fixed:
     Bug 21766: Crash with e10s enabled while trying to download a file
     Bug 21886: Download is stalled in non-e10s mode
     Bug 22471: Downloading files via the PDF viewer download button is broken
     Bug 22472: Fix FTP downloads when external helper app dialog is shown
     Bug 22610: Avoid crashes when canceling external helper app downloads
     Bug 22618: Downloading pdf file via file:/// is stalling
    
  • 08005067
    by Pier Angelo Vendrame at 2023-02-09T14:09:32+00:00
    Bug 40807: Added QRCode.js to toolkit/modules
    
  • 91b4fdf8
    by Richard Pospesel at 2023-02-09T14:09:32+00:00
    Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
    
    This patch adds a new about:preferences#connection page which allows
    modifying bridge, proxy, and firewall settings from within Tor Browser.
    All of the functionality present in tor-launcher's Network
    Configuration panel is present:
    
     - Setting built-in bridges
     - Requesting bridges from BridgeDB via moat
     - Using user-provided bridges
     - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
     - Setting firewall ports
     - Viewing and Copying Tor's logs
     - The Networking Settings in General preferences has been removed
    
    Bug 40774: Update about:preferences page to match new UI designs
    
  • a598b057
    by Richard Pospesel at 2023-02-09T14:09:33+00:00
    Bug 27476: Implement about:torconnect captive portal within Tor Browser
    
    - implements new about:torconnect page as tor-launcher replacement
    - adds tor connection status to url bar and tweaks UX when not online
    - adds new torconnect component to browser
    - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
    - adds warning/error box to about:preferences#tor when not connected to tor
    - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP)
    - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)
    
    Bug 40773: Update the about:torconnect frontend page to match additional UI flows
    
  • 814475bf
    by Arthur Edelstein at 2023-02-09T14:09:33+00:00
    Bug 12620: TorBrowser regression tests
    
    Regression tests for Bug #2950: Make Permissions Manager memory-only
    
    Regression tests for TB4: Tor Browser's Firefox preference overrides.
    
    Note: many more functional tests could be made here
    
    Regression tests for #2874: Block Components.interfaces from content
    
    Bug 18923: Add a script to run all Tor Browser specific tests
    
    Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
    
  • 455c5291
    by Kathy Brade at 2023-02-09T14:09:33+00:00
    Bug 4234: Use the Firefox Update Process for Tor Browser.
    
    The following files are never updated:
      TorBrowser/Data/Browser/profiles.ini
      TorBrowser/Data/Browser/profile.default/bookmarks.html
      TorBrowser/Data/Tor/torrc
    Mac OS: Store update metadata under TorBrowser/UpdateInfo.
    Removed the %OS_VERSION% component from the update URL (13047) and
      added support for minSupportedOSVersion, an attribute of the
      <update> element that may be used to trigger Firefox's
      "unsupported platform" behavior.
    Hide the "What's new" links (set app.releaseNotesURL value to about:blank).
    Windows: disable "runas" code path in updater (15201).
    Windows: avoid writing to the registry (16236).
    Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
      16014, 16909, 24476, and 25909.
    
    Also fix Bug 26049: reduce the delay before the update prompt is displayed.
    Instead of Firefox's 2 days, we use 1 hour (after which time the update
    doorhanger will be displayed).
    
    Also fix bug 27221: purge the startup cache if the Tor Browser
    version changed (even if the Firefox version and build ID did
    not change), e.g., after a minor Tor Browser update.
    
    Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
    
    Bug 26048: potentially confusing "restart to update" message
    
    Within the update doorhanger, remove the misleading message that mentions
    that windows will be restored after an update is applied, and replace the
    "Restart and Restore" button label with an existing
    "Restart to update Tor Browser" string.
    
    Bug 28885: notify users that update is downloading
    
    Add a "Downloading Tor Browser update" item which appears in the
    hamburger (app) menu while the update service is downloading a MAR
    file. Before this change, the browser did not indicate to the user
    that an update was in progress, which is especially confusing in
    Tor Browser because downloads often take some time. If the user
    clicks on the new menu item, the about dialog is opened to allow
    the user to see download progress.
    
    As part of this fix, the update service was changed to always show
    update-related messages in the hamburger menu, even if the update
    was started in the foreground via the about dialog or via the
    "Check for Tor Browser Update" toolbar menu item. This change is
    consistent with the Tor Browser goal of making sure users are
    informed about the update process.
    
    Removed #28885 parts of this patch which have been uplifted to Firefox.
    
  • 5d621939
    by Kathy Brade at 2023-02-09T14:09:34+00:00
    Bug 13379: Sign our MAR files.
    
    Configure with --enable-verify-mar (when updating, require a valid
      signature on the MAR file before it is applied).
    Use the Tor Browser version instead of the Firefox version inside the
      MAR file info block (necessary to prevent downgrade attacks).
    Use NSS on all platforms for checking MAR signatures (instead of using
      OS-native APIs, which Mozilla does on Mac OS and Windows). So that the
      NSS and NSPR libraries the updater depends on can be found at runtime,
      we add the firefox directory to the shared library search path on macOS.
      On Linux, rpath is used by Mozilla to solve that problem, but that
      approach won't work on macOS because the updater executable is copied
      during the update process to a location that is under TorBrowser-Data,
      and the location of TorBrowser-Data varies.
    
    Also includes the fix for bug 18900.
    
    Bug 19121: reinstate the update.xml hash check
    
    Revert most changes from Mozilla Bug 1373267 "Remove hashFunction and
    hashValue attributes from nsIUpdatePatch and code related to these
    attributes." Changes to the tests were not reverted; the tests have
    been changed significantly and we do not run automated updater tests
    for Tor Browser at this time.
    
    Also partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.
    
    Revert the nsUpdateService.js changes from Mozilla Bug 862173 "don't
    verify mar file hash when using mar signing to verify the mar file
    (lessens main thread I/O)."
    
    Changes to the tests were not reverted; the tests have been changed
    significantly and we do not run automated updater tests for
    Tor Browser at this time.
    
    We kept the addition to the AppConstants API in case other JS code
    references it in the future.
    
  • 3e1e97ca
    by Kathy Brade at 2023-02-09T14:09:34+00:00
    Bug 16940: After update, load local change notes.
    
    Add an about:tbupdate page that displays the first section from
    TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
    post-update page (typically our blog entry for the release).
    
    Always load about:tbupdate in a content process, but implement the
    code that reads the file system (changelog) in the chrome process
    for compatibility with future sandboxing efforts.
    
    Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
    changelog page that is designed to be displayed via a link that is on
    about:tor.
    
  • 8506b577
    by Georg Koppen at 2023-02-09T14:09:34+00:00
    Bug 32658: Create a new MAR signing key
    
    It's time for our rotation again: Move the backup key in the front
    position and add a new backup key.
    
    Bug 33803: Move our primary nightly MAR signing key to tor-browser
    
    Bug 33803: Add a secondary nightly MAR signing key
    
  • f2547767
    by Mike Perry at 2023-02-09T14:09:35+00:00
    Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
    
    eBay and Amazon don't treat Tor users very well. Accounts often get locked and
    payments reversed.
    
    Also:
    Bug 16322: Update DuckDuckGo search engine
    
    We are replacing the clearnet URL with an onion service one (thanks to a
    patch by a cypherpunk) and are removing the duplicated DDG search
    engine. Duplicating DDG happend due to bug 1061736 where Mozilla
    included DDG itself into Firefox. Interestingly, this caused breaking
    the DDG search if _javascript_ is disabled as the Mozilla engine, which
    gets loaded earlier, does not use the html version of the search page.
    Moreover, the Mozilla engine tracked where the users were searching from
    by adding a respective parameter to the search query. We got rid of that
    feature as well.
    
    Also:
    This fixes bug 20809: the DuckDuckGo team has changed its server-side
    code in a way that lets users with _javascript_ enabled use the default
    landing page while those without _javascript_ available get redirected
    directly to the non-JS page. We adapt the search engine URLs
    accordingly.
    
    Also fixes bug 29798 by making sure we only specify the Google search
    engine we actually ship an .xml file for.
    
    Also regression tests.
    
    squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
    
    Bug 40494: Update Startpage search provider
    
    squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
    
    Bug 40438: Add Blockchair as a search engine
    
    Bug 33342: Avoid disconnect search addon error after removal.
    
    We removed the addon in #32767, but it was still being loaded
    from addonStartup.json.lz4 and throwing an error on startup
    because its resource: location is not available anymore.
    
  • 8c1a2d3b
    by Richard Pospesel at 2023-02-09T14:09:35+00:00
    Bug 23247: Communicating security expectations for .onion
    
    Encrypting pages hosted on Onion Services with SSL/TLS is redundant
    (in terms of hiding content) as all traffic within the Tor network is
    already fully encrypted.  Therefore, serving HTTP pages from an Onion
    Service is more or less fine.
    
    Prior to this patch, Tor Browser would mostly treat pages delivered
    via Onion Services as well as pages delivered in the ordinary fashion
    over the internet in the same way.  This created some inconsistencies
    in behaviour and misinformation presented to the user relating to the
    security of pages delivered via Onion Services:
    
     - HTTP Onion Service pages did not have any 'lock' icon indicating
       the site was secure
     - HTTP Onion Service pages would be marked as unencrypted in the Page
       Info screen
     - Mixed-mode content restrictions did not apply to HTTP Onion Service
       pages embedding Non-Onion HTTP content
    
    This patch fixes the above issues, and also adds several new 'Onion'
    icons to the mix to indicate all of the various permutations of Onion
    Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
    
    Strings for Onion Service Page Info page are pulled from Torbutton's
    localization strings.
    
  • 967f065a
    by Kathy Brade at 2023-02-09T14:09:35+00:00
    Bug 30237: Add v3 onion services client authentication prompt
    
    When Tor informs the browser that client authentication is needed,
    temporarily load about:blank instead of about:neterror and prompt
    for the user's key.
    
    If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
    control port command to add the key (via Torbutton's control port
    module) and reload the page.
    
    If the user cancels the prompt, display the standard about:neterror
    "Unable to connect" page. This requires a small change to
    browser/actors/NetErrorChild.jsm to account for the fact that the
    docShell no longer has the failedChannel information. The failedChannel
    is used to extract TLS-related error info, which is not applicable
    in the case of a canceled .onion authentication prompt.
    
    Add a leaveOpen option to PopupNotifications.show so we can display
    error messages within the popup notification doorhanger without
    closing the prompt.
    
    Add support for onion services strings to the TorStrings module.
    
    Add support for Tor extended SOCKS errors (Tor proposal 304) to the
    socket transport and SOCKS layers. Improved display of all of these
    errors will be implemented as part of bug 30025.
    
    Also fixes bug 19757:
     Add a "Remember this key" checkbox to the client auth prompt.
    
     Add an "Onion Services Authentication" section within the
     about:preferences "Privacy & Security section" to allow
     viewing and removal of v3 onion client auth keys that have
     been stored on disk.
    
    Also fixes bug 19251: use enhanced error pages for onion service errors.
    
  • b9b791d5
    by Alex Catarineu at 2023-02-09T14:09:36+00:00
    Bug 21952: Implement Onion-Location
    
    Whenever a valid Onion-Location HTTP header (or corresponding HTML
    <meta> http-equiv attribute) is found in a document load, we either
    redirect to it (if the user opted-in via preference) or notify the
    presence of an onionsite alternative with a badge in the urlbar.
    
  • fad1a632
    by Pier Angelo Vendrame at 2023-02-09T14:09:36+00:00
    Bug 40458: Implement .tor.onion aliases
    
    We have enabled HTTPS-Only mode, therefore we do not need
    HTTPS-Everywhere anymore.
    However, we want to keep supporting .tor.onion aliases (especially for
    securedrop).
    Therefore, in this patch we implemented the parsing of HTTPS-Everywhere
    rulesets, and the redirect of .tor.onion domains.
    Actually, Tor Browser believes they are actual domains. We change them
    on the fly on the SOCKS proxy requests to resolve the domain, and on
    the code that verifies HTTPS certificates.
    
  • 68e1e05e
    by Pier Angelo Vendrame at 2023-02-09T14:09:36+00:00
    Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser
    
    This patch associates the about:manual page to a translated page that
    must be injected to browser/omni.ja after the build.
    The content must be placed in chrome/browser/content/browser/manual/, so
    that is then available at chrome://browser/content/manual/.
    We preferred giving absolute freedom to the web team, rather than having
    to change the patch in case of changes on the documentation.
    
  • bd46b8bd
    by Pier Angelo Vendrame at 2023-02-09T14:09:37+00:00
    Bug 41435: Add a Tor Browser migration function
    
    For now this function only deletes old language packs for which we are
    already packaging the strings with the application.
    
  • 6cf333b1
    by p13dz at 2023-02-09T14:09:37+00:00
    Bug 40283: Workaround for the file upload bug
    
    
    (cherry picked from commit c23f2f397327ee46a1a4de57acf206fd83e8e170)

30 changed files:

The diff was not included because it is too large.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits