[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-147.0a1-16.0-2] 2 commits: Bug 2013390: Test file extension before testing zip and tarfiles.r=ahal

Title: GitLab

brizental pushed to branch tor-browser-147.0a1-16.0-2 at The Tor Project / Applications / Tor Browser

Commits:

  • bd2b83d9
    by Beatriz Rizental at 2026-02-05T19:38:10+01:00 
    Bug 2013390: Test file extension before testing zip and tarfiles.r=ahal

The tarfile check specifically has been returning false positives on DMG
files.

Differential Revision: https://phabricator.services.mozilla.com/D281070
  • e2e81683
    by Beatriz Rizental at 2026-02-05T19:38:10+01:00 
    Bug 2013358: Drop Python <3.13 requirement from manifestparser.r=ahal

Differential Revision: https://phabricator.services.mozilla.com/D281036

2 changed files:

Changes:

  • testing/mozbase/manifestparser/setup.py
    ... ... @@ -25,6 +25,7 @@ setup(
    25 25 
             "Programming Language :: Python :: 3.10",
    26 26 
             "Programming Language :: Python :: 3.11",
    27 27 
             "Programming Language :: Python :: 3.12",
    28 
    +        "Programming Language :: Python :: 3.13",
    28 29 
         ],
    29 30 
         # Get strings from http://pypi.python.org/pypi?%3Aaction=list_classifiers
    30 31 
         keywords="mozilla manifests",
    ... ... @@ -39,5 +40,5 @@ setup(
    39 40 
           [console_scripts]
    40 41 
           manifestparser = manifestparser.cli:main
    41 42 
           """,
    42 
    -    python_requires=">=3.8, <3.13",
    43 
    +    python_requires=">=3.8",
    43 44 
     )

  • testing/mozbase/mozinstall/mozinstall/mozinstall.py
    ... ... @@ -121,12 +121,12 @@ def install(src, dest):
    121 121 
             if src.lower().endswith(".msix"):
    122 122 
                 # MSIX packages _are_ ZIP files, so we need to look for them first.
    123 123 
                 install_dir = _install_msix(src)
    124 
    -        elif zipfile.is_zipfile(src) or tarfile.is_tarfile(src):
    125 
    -            install_dir = mozfile.extract(src, dest)[0]
    126 124 
             elif src.lower().endswith(".dmg"):
    127 125 
                 install_dir = _install_dmg(src, dest)
    128 126 
             elif src.lower().endswith(".exe"):
    129 127 
                 install_dir = _install_exe(src, dest)
    128 
    +        elif zipfile.is_zipfile(src) or tarfile.is_tarfile(src):
    129 
    +            install_dir = mozfile.extract(src, dest)[0]
    130 130 
             else:
    131 131 
                 raise InvalidSource(f"{src} is not a valid installer file")
    132 132

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ffe41bf4e4d887a6b6254d399aca494705c982bc...e2e81683c651349e0f4d45a550037b254997da69 at 1770317353 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx