[or-cvs] note an assert trigger, if you use an old broken netscape s...

[arma@seul.org (Roger Dingledine)]

Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	buffers.c 
Log Message:
note an assert trigger, if you use an old broken netscape socks4


Index: buffers.c
===================================================================
RCS file: /home/or/cvsroot/src/or/buffers.c,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -d -r1.59 -r1.60
--- buffers.c	19 Dec 2003 05:09:50 -0000	1.59
+++ buffers.c	30 Jan 2004 15:15:11 -0000	1.60
@@ -532,6 +532,9 @@
       }
       log_fn(LOG_DEBUG,"Everything is here. Success.");
       strcpy(req->address, socks4_prot == socks4 ? tmpbuf : startaddr);
+      /* XXX on very old netscapes (socks4) the next line triggers an
+       * assert, because next-buf->mem+1 is greater than buf->datalen.
+       */
       buf_remove_from_front(buf, next-buf->mem+1); /* next points to the final \0 on inbuf */
       return 1;