[tor-commits] [tor/master] Tell static analyzer that having ntservice functions not exist is ok

[nickm@xxxxxxxxxxxxxx]

commit 77246dc0d8b90e99bb411475da1911919799dae8
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Wed Jan 15 10:30:03 2020 -0500

    Tell static analyzer that having ntservice functions not exist is ok
    
    When we made these functions exist unconditionally (as macros on
    non-windows platforms), we started to get a dead-code warning on
    Coverity.  We now use a macro to tell coverity not to worry about
    this particular dead-code instance.
---
 src/app/main/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/main/main.c b/src/app/main/main.c
index 36f85c6a4..b533406ea 100644
--- a/src/app/main/main.c
+++ b/src/app/main/main.c
@@ -1240,7 +1240,7 @@ tor_run_main(const tor_main_configuration_t *tor_cfg)
 
   int done = 0;
   result = nt_service_parse_options(argc, argv, &done);
-  if (done)
+  if (POSSIBLE(done))
     goto done;
 
   pubsub_install();



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits