[tor-commits] [tor/maint-0.4.6] test: Remove HSv2 protover specific test

[dgoulet@xxxxxxxxxxxxxx]

commit 986730e82c69d4a29e3b00cde5a7bf7a15a3b94b
Author: David Goulet <dgoulet@xxxxxxxxxxxxxx>
Date:   Wed Jan 19 13:36:23 2022 -0500

    test: Remove HSv2 protover specific test
    
    HSv2 is not advertised as a supported protocol version anymore.
    
    This was introduced with the merge-forward of commit 72041c63064b461e
    which didn't fix the unit test.
    
    Fixes #40549
    
    Signed-off-by: David Goulet <dgoulet@xxxxxxxxxxxxxx>
---
 src/test/test_protover.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/test/test_protover.c b/src/test/test_protover.c
index 44febe0fa6..16f0279871 100644
--- a/src/test/test_protover.c
+++ b/src/test/test_protover.c
@@ -348,9 +348,6 @@ test_protover_supports_version(void *arg)
 /* Deprecated HSIntro versions */
 #define PROTOVER_HS_INTRO_DEPRECATED_1 1
 #define PROTOVER_HS_INTRO_DEPRECATED_2 2
-/* Highest supported HSv2 introduce protocol version.
- * It's not clear if we actually support version 2, see #25068. */
-#define PROTOVER_HS_INTRO_V2 3
 
 /* HSv2 Rend and HSDir protocol versions. */
 #define PROTOVER_HS_RENDEZVOUS_POINT_V2 1
@@ -433,12 +430,6 @@ test_protover_supported_protocols(void *arg)
   tt_assert(!protocol_list_supports_protocol(supported_protocols,
                                             PRT_HSINTRO,
                                             PROTOVER_HS_INTRO_DEPRECATED_2));
-  /* We could test legacy HSIntro by calling rend_service_update_descriptor(),
-   * and checking the protocols field. But that's unlikely to change, so
-   * we just use a hard-coded value. */
-  tt_assert(protocol_list_supports_protocol(supported_protocols,
-                                            PRT_HSINTRO,
-                                            PROTOVER_HS_INTRO_V2));
   /* Test for HSv3 HSIntro */
   tt_assert(protocol_list_supports_protocol(supported_protocols,
                                             PRT_HSINTRO,



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits