[tor-commits] [torspec] 05/10: tor-spec: fix ambitious formulation in VERSIONS

[gitolite role via tor-commits <tor-commits@xxxxxxxxxxxxxxxxxxxx>]

This is an automated email from the git hooks/post-receive script.

dgoulet pushed a commit to branch main
in repository torspec.

commit 31c325434ea540f1ca27bc10e88fb13ad960a16b
Author: Emil Engler <me@xxxxxxxxxxxxxx>
AuthorDate: Thu Dec 22 19:31:01 2022 +0100

    tor-spec: fix ambitious formulation in VERSIONS
    
    This commit fixes an ambitious formulation within the definition of the
    VERSIONS cells. It says, that a VERSIONS cell with an odd number of
    bytes is invalid. This statement is not true, because the CircID (2
    bytes for VERSIONS cells), Command (1 byte) and Length (2 byte) make up
    5 bytes, which is an odd number. Adding an odd number to an even number
    of bytes (the payload in this case) always results in an odd number.
---
 tor-spec.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tor-spec.txt b/tor-spec.txt
index f728478..2116097 100644
--- a/tor-spec.txt
+++ b/tor-spec.txt
@@ -662,7 +662,7 @@ see tor-design.pdf.
    versions cell they received.  If they have no such version in common,
    they cannot communicate and MUST close the connection.  Either party MUST
    close the connection if the versions cell is not well-formed (for example,
-   if it contains an odd number of bytes).
+   if the payload contains an odd number of bytes).
 
    Any VERSIONS cells sent after the first VERSIONS cell MUST be ignored.
    (To be interpreted correctly, later VERSIONS cells MUST have a CIRCID_LEN

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits