[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-102.7.0esr-12.5-1] 2 commits: fixup! Firefox preference overrides.

Title: GitLab

Pier Angelo Vendrame pushed to branch tor-browser-102.7.0esr-12.5-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 43da6d54
    by Pier Angelo Vendrame at 2023-01-30T14:40:42+01:00 
    fixup! Firefox preference overrides.

Bug 40788: Disable AS's calls to home.

We now also disable more AS tasks, but we could see it as a part of the
preferences we set to be sure it stays disabled.
  • e8921475
    by Pier Angelo Vendrame at 2023-01-30T14:41:32+01:00 
    Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled.

The URL query stripping service is enabled only in nightly builds,
still it is initialized and remote settings are downloaded.
This adds a condition that prevents the service from being initialized
if disabled.

Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594
We should remove this patch if Mozilla decides that this is a problem
also for them, or if they do not but we decide to use the feature.

2 changed files:

Changes:

  • browser/app/profile/001-base-profile.js
    ... ... @@ -178,6 +178,15 @@ pref("browser.newtabpage.activity-stream.default.sites", "");
    178 178 
     pref("browser.newtabpage.activity-stream.feeds.telemetry", false);
    179 179 
     pref("browser.newtabpage.activity-stream.telemetry", false);
    180 180
    181 
    +// tor-browser#40788: disable AS's calls to home.
    182 
    +// Notice that null is between quotes because it is a JSON string.
    183 
    +// Keep checked firefox.js to see if new entries are added.
    184 
    +pref("browser.newtabpage.activity-stream.asrouter.providers.cfr", "null");
    185 
    +pref("browser.newtabpage.activity-stream.asrouter.providers.whats-new-panel", "null");
    186 
    +pref("browser.newtabpage.activity-stream.asrouter.providers.message-groups", "null");
    187 
    +pref("browser.newtabpage.activity-stream.asrouter.providers.snippets", "null");
    188 
    +pref("browser.newtabpage.activity-stream.asrouter.providers.messaging-experiments", "null");
    189 
    +
    181 190 
     // Disable fetching asrouter.ftl and related console errors (tor-browser#40763).
    182 191 
     pref("browser.newtabpage.activity-stream.asrouter.useRemoteL10n", false);
    183 192

  • browser/components/BrowserGlue.jsm
    ... ... @@ -2698,11 +2698,23 @@ BrowserGlue.prototype = {
    2698 2698
    2699 2699 
           {
    2700 2700 
             task: () => {
    2701 
    -          // Init the url query stripping list.
    2702 
    -          let urlQueryStrippingListService = Cc[
    2703 
    -            "@mozilla.org/query-stripping-list-service;1"
    2704 
    -          ].getService(Ci.nsIURLQueryStrippingListService);
    2705 
    -          urlQueryStrippingListService.init();
    2701 
    +          // tor-browser#40788: Do not initialize
    2702 
    +          // nsIURLQueryStrippingListService to prevent it from initializing
    2703 
    +          // its remote settings if it's disabled.
    2704 
    +          // See also https://bugzilla.mozilla.org/show_bug.cgi?id=1812594
    2705 
    +          let enabledPref = "privacy.query_stripping.enabled";
    2706 
    +          let enabledPBMPref = "privacy.query_stripping.enabled.pbmode";
    2707 
    +
    2708 
    +          if (
    2709 
    +            Services.prefs.getBoolPref(enabledPref, false) ||
    2710 
    +            Services.prefs.getBoolPref(enabledPBMPref, false)
    2711 
    +          ) {
    2712 
    +            // Init the url query stripping list.
    2713 
    +            let urlQueryStrippingListService = Cc[
    2714 
    +              "@mozilla.org/query-stripping-list-service;1"
    2715 
    +            ].getService(Ci.nsIURLQueryStrippingListService);
    2716 
    +            urlQueryStrippingListService.init();
    2717 
    +          }
    2706 2718 
             },
    2707 2719 
           },
    2708 2720

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits