[tor-commits] [tor/master] prop250: Plug TorVersion memleak in disk_state_reset().

[nickm@xxxxxxxxxxxxxx]

commit f03c74c6315598b1a7634a4dfcdebbed1e147d08
Author: George Kadianakis <desnacked@xxxxxxxxxx>
Date:   Mon Jul 4 12:28:28 2016 +0300

    prop250: Plug TorVersion memleak in disk_state_reset().
---
 src/or/shared_random_state.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/or/shared_random_state.c b/src/or/shared_random_state.c
index 73df9c4..7d34334 100644
--- a/src/or/shared_random_state.c
+++ b/src/or/shared_random_state.c
@@ -597,10 +597,16 @@ disk_state_put_srv_line(const sr_srv_t *srv, config_line_t *line)
 static void
 disk_state_reset(void)
 {
+  /* Free allocated memory */
   config_free_lines(sr_disk_state->Commit);
   config_free_lines(sr_disk_state->SharedRandValues);
   config_free_lines(sr_disk_state->ExtraLines);
+  tor_free(sr_disk_state->TorVersion);
+
+  /* Clean up the struct */
   memset(sr_disk_state, 0, sizeof(*sr_disk_state));
+
+  /* Reset it with useful data */
   sr_disk_state->magic_ = SR_DISK_STATE_MAGIC;
   sr_disk_state->TorVersion = tor_strdup(get_version());
 }



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits