[tor-commits] [tor/master] specify when to run make distcheck

[nickm@xxxxxxxxxxxxxx]

commit 934f85f87aa17bf6e1ffad37df8d8d4fb7bf404e
Author: Chelsea H. Komlo <chelsea.komlo@xxxxxxxxx>
Date:   Sun Jul 9 16:17:21 2017 -0400

    specify when to run make distcheck
---
 doc/HACKING/CodingStandards.md | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/doc/HACKING/CodingStandards.md b/doc/HACKING/CodingStandards.md
index da8ce62..cc1ba8e 100644
--- a/doc/HACKING/CodingStandards.md
+++ b/doc/HACKING/CodingStandards.md
@@ -7,7 +7,7 @@ tl;dr:
    - Document your functions
    - Write unit tests
    - Run `make check` before submitting a patch
-   - Run `make distcheck` to ensure the distribution works
+   - Run `make distcheck` if you have made changes to build system components
    - Add a file in `changes` for your branch.
 
 Patch checklist
@@ -37,6 +37,11 @@ If you are submitting a major patch or new feature, or want to in the future...
    - Set up Chutney and Stem, see HACKING/WritingTests.md
    - Run `make test-full` to test against all unit and integration tests.
 
+If you have changed build system components:
+   - Please run `make distcheck`
+   - For example, if you have changed Makefiles, autoconf files, or anything
+     else that impacts the build system.
+
 How we use Git branches
 =======================
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits