[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/mullvad-browser][mullvad-browser-128.0esr-14.0-2] 3 commits: fixup! Add CI for Base Browser

Title: GitLab

Pier Angelo Vendrame pushed to branch mullvad-browser-128.0esr-14.0-2 at The Tor Project / Applications / Mullvad Browser

Commits:

  • f0717dcb
    by Beatriz Rizental at 2024-07-29T17:00:34+02:00 
    fixup! Add CI for Base Browser
  • 9448012d
    by Pier Angelo Vendrame at 2024-07-30T09:06:25+02:00 
    fixup! Firefox preference overrides.

Bug 42872: Disable translations.

Currently, the UX is kinda bad in Tor Browser (RFP might be a reason).
Also, we should audit it first, to make sure it is not a
fingerprinting concern (or if it is, we should make sure it is an
acceptable one).
  • b94825b7
    by Beatriz Rizental at 2024-07-30T12:25:35+02:00 
    Revert "Bug 42725: Fix upstream lint issues"

This reverts commit 0c49b3f6b7101e95e33f697234648eeaef070a46.

5 changed files:

Changes:

  • .gitlab/ci/lint.yml
    ... ... @@ -39,9 +39,8 @@ eslint:
    39 39 
             # The plugin implementing custom checks.
    40 40 
             - 'tools/lint/eslint/eslint-plugin-mozilla/**'
    41 41 
             - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**'
    42 
    -    # Run job whenever a new tag is created
    43 
    -    # or whenever a commit is merged to a protected branch
    44 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    42 
    +    # Run job whenever a commit is merged to a protected branch
    43 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    45 44
    46 45 
     stylelint:
    47 46 
       extends: .base
    ... ... @@ -59,9 +58,8 @@ stylelint:
    59 58 
             # Run when stylelint policies change.
    60 59 
             - '**/.stylelintignore'
    61 60 
             - '**/*stylelintrc*'
    62 
    -    # Run job whenever a new tag is created
    63 
    -    # or whenever a commit is merged to a protected branch
    64 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    61 
    +    # Run job whenever a commit is merged to a protected branch
    62 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    65 63
    66 64 
     py-black:
    67 65 
       extends: .base
    ... ... @@ -80,9 +78,8 @@ py-black:
    80 78 
             - '**/*.mozbuild'
    81 79 
             - 'pyproject.toml'
    82 80 
             - 'tools/lint/black.yml'
    83 
    -    # Run job whenever a new tag is created
    84 
    -    # or whenever a commit is merged to a protected branch
    85 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    81 
    +    # Run job whenever a commit is merged to a protected branch
    82 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    86 83
    87 84 
     py-ruff:
    88 85 
       extends: .base
    ... ... @@ -101,9 +98,8 @@ py-ruff:
    101 98 
             - 'tools/lint/ruff.yml'
    102 99 
             - 'tools/lint/python/ruff.py'
    103 100 
             - 'tools/lint/python/ruff_requirements.txt'
    104 
    -    # Run job whenever a new tag is created
    105 
    -    # or whenever a commit is merged to a protected branch
    106 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    101 
    +    # Run job whenever a commit is merged to a protected branch
    102 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    107 103
    108 104 
     yaml:
    109 105 
       extends: .base
    ... ... @@ -118,9 +114,8 @@ yaml:
    118 114 
             - '**/*.yml'
    119 115 
             - '**/*.yaml'
    120 116 
             - '**/.ymllint'
    121 
    -    # Run job whenever a new tag is created
    122 
    -    # or whenever a commit is merged to a protected branch
    123 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    117 
    +    # Run job whenever a commit is merged to a protected branch
    118 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    124 119
    125 120 
     shellcheck:
    126 121 
       extends: .base
    ... ... @@ -134,9 +129,8 @@ shellcheck:
    134 129 
             #
    135 130 
             - '**/*.sh'
    136 131 
             - 'tools/lint/shellcheck.yml'
    137 
    -    # Run job whenever a new tag is created
    138 
    -    # or whenever a commit is merged to a protected branch
    139 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    132 
    +    # Run job whenever a commit is merged to a protected branch
    133 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    140 134
    141 135 
     clang-format:
    142 136 
       extends: .base
    ... ... @@ -156,9 +150,8 @@ clang-format:
    156 150 
             - '**/*.m'
    157 151 
             - '**/*.mm'
    158 152 
             - 'tools/lint/clang-format.yml'
    159 
    -    # Run job whenever a new tag is created
    160 
    -    # or whenever a commit is merged to a protected branch
    161 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    153 
    +    # Run job whenever a commit is merged to a protected branch
    154 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    162 155
    163 156 
     rustfmt:
    164 157 
       extends: .base
    ... ... @@ -172,9 +165,8 @@ rustfmt:
    172 165 
             #
    173 166 
             - '**/*.rs'
    174 167 
             - 'tools/lint/rustfmt.yml'
    175 
    -    # Run job whenever a new tag is created
    176 
    -    # or whenever a commit is merged to a protected branch
    177 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    168 
    +    # Run job whenever a commit is merged to a protected branch
    169 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    178 170
    179 171 
     fluent-lint:
    180 172 
       extends: .base
    ... ... @@ -189,9 +181,8 @@ fluent-lint:
    189 181 
             - '**/*.ftl'
    190 182 
             - 'tools/lint/fluent-lint.yml'
    191 183 
             - 'tools/lint/fluent-lint/exclusions.yml'
    192 
    -    # Run job whenever a new tag is created
    193 
    -    # or whenever a commit is merged to a protected branch
    194 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    184 
    +    # Run job whenever a commit is merged to a protected branch
    185 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    195 186
    196 187 
     localization:
    197 188 
       extends: .base
    ... ... @@ -208,9 +199,8 @@ localization:
    208 199 
             - 'third_party/python/compare-locales/**'
    209 200 
             - 'third_party/python/fluent/**'
    210 201 
             - 'tools/lint/l10n.yml'
    211 
    -    # Run job whenever a new tag is created
    212 
    -    # or whenever a commit is merged to a protected branch
    213 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    202 
    +    # Run job whenever a commit is merged to a protected branch
    203 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    214 204
    215 205 
     mingw-capitalization:
    216 206 
       extends: .base
    ... ... @@ -227,9 +217,8 @@ mingw-capitalization:
    227 217 
             - '**/*.c'
    228 218 
             - '**/*.h'
    229 219 
             - 'tools/lint/mingw-capitalization.yml'
    230 
    -    # Run job whenever a new tag is created
    231 
    -    # or whenever a commit is merged to a protected branch
    232 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    220 
    +    # Run job whenever a commit is merged to a protected branch
    221 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    233 222
    234 223 
     mscom-init:
    235 224 
       extends: .base
    ... ... @@ -246,9 +235,8 @@ mscom-init:
    246 235 
             - '**/*.c'
    247 236 
             - '**/*.h'
    248 237 
             - 'tools/lint/mscom-init.yml'
    249 
    -    # Run job whenever a new tag is created
    250 
    -    # or whenever a commit is merged to a protected branch
    251 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    238 
    +    # Run job whenever a commit is merged to a protected branch
    239 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    252 240
    253 241 
     file-whitespace:
    254 242 
       extends: .base
    ... ... @@ -277,9 +265,8 @@ file-whitespace:
    277 265 
             - '**/*.webidl'
    278 266 
             - '**/*.xhtml'
    279 267 
             - 'tools/lint/file-whitespace.yml'
    280 
    -    # Run job whenever a new tag is created
    281 
    -    # or whenever a commit is merged to a protected branch
    282 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    268 
    +    # Run job whenever a commit is merged to a protected branch
    269 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    283 270
    284 271 
     test-manifest:
    285 272 
       extends: .base
    ... ... @@ -294,9 +281,8 @@ test-manifest:
    294 281 
             - '**/*.ini'
    295 282 
             - 'python/mozlint/**'
    296 283 
             - 'tools/lint/**'
    297 
    -    # Run job whenever a new tag is created
    298 
    -    # or whenever a commit is merged to a protected branch
    299 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    284 
    +    # Run job whenever a commit is merged to a protected branch
    285 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'
    300 286
    301 287 
     trojan-source:
    302 288 
       extends: .base
    ... ... @@ -315,6 +301,5 @@ trojan-source:
    315 301 
             - '**/*.py'
    316 302 
             - '**/*.rs'
    317 303 
             - 'tools/lint/trojan-source.yml'
    318 
    -    # Run job whenever a new tag is created
    319 
    -    # or whenever a commit is merged to a protected branch
    320 
    -    - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true'
    304 
    +    # Run job whenever a commit is merged to a protected branch
    305 
    +    - if: $CI_COMMIT_REF_PROTECTED == 'true'

  • browser/app/profile/001-base-profile.js
    ... ... @@ -259,6 +259,11 @@ pref("browser.newtabpage.activity-stream.asrouter.providers.messaging-experiment
    259 259 
     // Disable fetching asrouter.ftl and related console errors (tor-browser#40763).
    260 260 
     pref("browser.newtabpage.activity-stream.asrouter.useRemoteL10n", false);
    261 261
    262 
    +// tor-browser#42872, #42555: Disable translations.
    263 
    +// Translation have a bad UX in 128 (and with our config). Maybe we will
    264 
    +// re-enable after auditing and fixing the UX.
    265 
    +pref("browser.translations.enable", false);
    266 
    +
    262 267 
     // tor-browser#41945 - disable automatic cookie banners dismissal until
    263 268 
     // we're sure it does not causes fingerprinting risks or other issues.
    264 269 
     pref("cookiebanners.service.mode", 0);

  • dom/base/nsGlobalWindowOuter.cpp
    ... ... @@ -7296,7 +7296,7 @@ void nsGlobalWindowOuter::InitWasOffline() { mWasOffline = NS_IsOffline(); }
    7296 7296
    7297 7297 
     #if defined(_WINDOWS_) && !defined(MOZ_WRAPPED_WINDOWS_H)
    7298 7298 
     #  pragma message( \
    7299 
    -          "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON)
    7299 
    +      "wrapper failure reason: " MOZ_WINDOWS_WRAPPER_DISABLED_REASON)
    7300 7300 
     #  error "Never include unwrapped windows.h in this file!"
    7301 7301 
     #endif
    7302 7302

  • dom/security/nsContentSecurityUtils.cpp
    ... ... @@ -1332,20 +1332,20 @@ void nsContentSecurityUtils::AssertAboutPageHasCSP(Document* aDocument) {
    1332 1332 
       // This allowlist contains about: pages that are permanently allowed to
    1333 1333 
       // render without a CSP applied.
    1334 1334 
       static nsLiteralCString sAllowedAboutPagesWithNoCSP[] = {
    1335 
    -    // about:blank is a special about page -> no CSP
    1336 
    -    "about:blank"_ns,
    1337 
    -    // about:srcdoc is a special about page -> no CSP
    1338 
    -    "about:srcdoc"_ns,
    1339 
    -    // about:sync-log displays plain text only -> no CSP
    1340 
    -    "about:sync-log"_ns,
    1341 
    -    // about:logo just displays the firefox logo -> no CSP
    1342 
    -    "about:logo"_ns,
    1343 
    -    // about:sync is a special mozilla-signed developer addon with low usage
    1344 
    -    // ->
    1345 
    -    // no CSP
    1346 
    -    "about:sync"_ns,
    1335 
    +      // about:blank is a special about page -> no CSP
    1336 
    +      "about:blank"_ns,
    1337 
    +      // about:srcdoc is a special about page -> no CSP
    1338 
    +      "about:srcdoc"_ns,
    1339 
    +      // about:sync-log displays plain text only -> no CSP
    1340 
    +      "about:sync-log"_ns,
    1341 
    +      // about:logo just displays the firefox logo -> no CSP
    1342 
    +      "about:logo"_ns,
    1343 
    +      // about:sync is a special mozilla-signed developer addon with low usage
    1344 
    +      // ->
    1345 
    +      // no CSP
    1346 
    +      "about:sync"_ns,
    1347 1347 
     #  if defined(ANDROID)
    1348 
    -    "about:config"_ns,
    1348 
    +      "about:config"_ns,
    1349 1349 
     #  endif
    1350 1350 
       };
    1351 1351

  • modules/libpref/Preferences.cpp
    ... ... @@ -6100,8 +6100,7 @@ void UnloadPrefsModule() { Preferences::Shutdown(); }
    6100 6100
    6101 6101 
     // Preference Sanitization Related Code ---------------------------------------
    6102 6102
    6103 
    -#define PREF_LIST_ENTRY(s) \
    6104 
    -  { s, (sizeof(s) / sizeof(char)) - 1 }
    6103 
    +#define PREF_LIST_ENTRY(s) {s, (sizeof(s) / sizeof(char)) - 1}
    6105 6104 
     struct PrefListEntry {
    6106 6105 
       const char* mPrefBranch;
    6107 6106 
       size_t mLen;

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits