[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[or-cvs] clean out some old comments
Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home/arma/work/onion/cvs/src/or
Modified Files:
connection.c
Log Message:
clean out some old comments
Index: connection.c
===================================================================
RCS file: /home/or/cvsroot/src/or/connection.c,v
retrieving revision 1.67
retrieving revision 1.68
diff -u -d -r1.67 -r1.68
--- connection.c 17 Jun 2003 22:18:26 -0000 1.67
+++ connection.c 24 Jun 2003 05:17:39 -0000 1.68
@@ -434,20 +434,10 @@
connection_write_cell_to_buf(&cell, conn);
}
- /* ???? If we might not have added a cell above, why are we
- * ???? increasing outbuf_flushlen? -NM */
/* The connection_write_cell_to_buf() call doesn't increase the flushlen
* (if link padding is on). So if there isn't a whole cell waiting-but-
* not-yet-flushed, we add a padding cell. Thus in any case the gap between
- * outbuf_datalen and outbuf_flushlen is at least sizeof(cell_t). -RD
- */
- /* XXXX actually, there are some subtle bugs lurking in here. They
- * have to do with the fact that we don't handle connection failure
- * cleanly. Sometimes we mark things to be closed later. Inside
- * connection_write_cell_to_buf, it returns successfully without
- * writing if the connection has been marked for close. We need to
- * look at all our failure cases more carefully and make sure they do
- * the right thing.
+ * outbuf_datalen and outbuf_flushlen is at least sizeof(cell_t).
*/
conn->outbuf_flushlen += sizeof(cell_t); /* instruct it to send a cell */
connection_start_writing(conn);