[tor-commits] [tor/master] stop asserting at boot

[nickm@xxxxxxxxxxxxxx]

commit 56771f392e68eb2f78180daab0d8f17c9284ad11
Author: Roger Dingledine <arma@xxxxxxxxxxxxxx>
Date:   Mon May 30 23:50:37 2011 -0400

    stop asserting at boot
    
    The patch for 3228 made us try to run init_keys() before we had loaded
    our state file, resulting in an assert inside init_keys. We had moved
    it too early in the function.
    
    Now it's later in the function, but still above the accounting calls.
---
 src/or/config.c |   23 +++++++++++------------
 1 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/or/config.c b/src/or/config.c
index f97e9b1..6635cac 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -1180,18 +1180,6 @@ options_act(or_options_t *old_options)
       return -1;
   }
 
-  /* We want to reinit keys as needed before we do much of anything else:
-     keys are important, and other things can depend on them. */
-  if (running_tor &&
-      (transition_affects_workers ||
-       (options->V3AuthoritativeDir && (!old_options ||
-                                        !old_options->V3AuthoritativeDir)))) {
-    if (init_keys() < 0) {
-      log_warn(LD_BUG,"Error initializing keys; exiting");
-      return -1;
-    }
-  }
-
   if (consider_adding_dir_authorities(options, old_options) < 0)
     return -1;
 
@@ -1237,6 +1225,17 @@ options_act(or_options_t *old_options)
     finish_daemon(options->DataDirectory);
   }
 
+  /* We want to reinit keys as needed before we do much of anything else:
+     keys are important, and other things can depend on them. */
+  if (transition_affects_workers ||
+      (options->V3AuthoritativeDir && (!old_options ||
+                                       !old_options->V3AuthoritativeDir))) {
+    if (init_keys() < 0) {
+      log_warn(LD_BUG,"Error initializing keys; exiting");
+      return -1;
+    }
+  }
+
   /* Write our PID to the PID file. If we do not have write permissions we
    * will log a warning */
   if (options->PidFile)



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits