[tor-commits] [flashproxy/rtmfp] Do log lines before sending responses in case there's an error in the send.

[dcf@xxxxxxxxxxxxxx]

commit efef83ad96cd4787b0cdaa97e266efbde0a90f72
Author: David Fifield <david@xxxxxxxxxxxxxxx>
Date:   Sat Jun 11 10:54:49 2011 -0700

    Do log lines before sending responses in case there's an error in the send.
---
 facilitator.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/facilitator.py b/facilitator.py
index a41ed6f..4d08673 100755
--- a/facilitator.py
+++ b/facilitator.py
@@ -227,16 +227,16 @@ class Handler(BaseHTTPServer.BaseHTTPRequestHandler):
 
         client_spec = data.getfirst("client")
         if client_spec is None:
-            self.send_error(400)
             log(u"client %s missing \"client\" param" % client_addr_s)
+            self.send_error(400)
             return
 
         try:
             reg = Reg.parse(client_spec, self.client_address[0])
         except ValueError, e:
-            self.send_error(400)
             log(u"client %s syntax error in %s: %s"
                 % (client_addr_s, repr(client_spec), repr(str(e))))
+            self.send_error(400)
             return
 
         log(u"client %s regs %s -> %s"



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits