[tor-commits] [tor/release-0.4.1] Give a more useful failure messgae when we fail to minherit().

[dgoulet@xxxxxxxxxxxxxx]

commit 93ddc51cbd325ef3d5cf3a5b9948ff65c09fc5aa
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Wed May 29 09:21:45 2019 -0400

    Give a more useful failure messgae when we fail to minherit().
    
    Part of ticket 30686.
---
 src/lib/crypt_ops/crypto_rand_fast.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/crypt_ops/crypto_rand_fast.c b/src/lib/crypt_ops/crypto_rand_fast.c
index b71ade81b..d2ce1a542 100644
--- a/src/lib/crypt_ops/crypto_rand_fast.c
+++ b/src/lib/crypt_ops/crypto_rand_fast.c
@@ -181,7 +181,11 @@ crypto_fast_rng_new_from_seed(const uint8_t *seed)
 #else
   /* We decided above that noinherit would always do _something_. Assert here
    * that we were correct. */
-  tor_assert(inherit != INHERIT_RES_KEEP);
+  tor_assertf(inherit != INHERIT_RES_KEEP,
+              "We failed to create a non-inheritable memory region, even "
+              "though we believed such a failure to be impossible! This is "
+              "probably a bug in Tor support for your platform; please report "
+              "it.");
 #endif
   return result;
 }



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits