[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-102.12.0esr-12.5-1] fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser



Title: GitLab

Pier Angelo Vendrame pushed to branch tor-browser-102.12.0esr-12.5-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 6ed4a3c6
    by Pier Angelo Vendrame at 2023-06-07T17:02:21+02:00
    fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
    
    Bug 41816: Workaround to fix the top navigation
    
    Using the top navigation does not always work as expected, because we
    pass a null connection state, instead of the actual state.
    We could start storing the state as a member, however further refactors
    are planned (see tor-browser#41710), so also directly asking the parent
    for the current state works as a quick&dirty workaround.
    

1 changed file:

Changes:

  • browser/components/torconnect/content/aboutTorConnect.js
    ... ... @@ -450,7 +450,7 @@ class AboutTorConnect {
    450 450
         if (state?.StateChanged) {
    
    451 451
           this.elements.connectButton.focus();
    
    452 452
         }
    
    453
    -    if (state.HasEverFailed) {
    
    453
    +    if (state?.HasEverFailed) {
    
    454 454
           this.setBreadcrumbsStatus(
    
    455 455
             BreadcrumbStatus.Active,
    
    456 456
             BreadcrumbStatus.Default,
    

  • _______________________________________________
    tor-commits mailing list
    tor-commits@xxxxxxxxxxxxxxxxxxxx
    https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits