[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/mullvad-browser][mullvad-browser-115.12.0esr-13.5-1] Bug 305: Disable setting default browser on Windows

Title: GitLab

richard pushed to branch mullvad-browser-115.12.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser

Commits:

  • dace2d0a
    by june wilde at 2024-06-10T12:49:40-07:00 
    Bug 305: Disable setting default browser on Windows
Until we can pull in upstream changes to fix breakage in setting
the Mullvad Browser as default in Windows 10/11 we're disabling
the ability to do so via about:preferences as well as via the
startup query dialog

2 changed files:

Changes:

  • browser/components/preferences/main.js
    ... ... @@ -1765,7 +1765,10 @@ var gMainPane = {
    1765 1765 
             "@mozilla.org/xre/directory-provider;1"
    1766 1766 
           ].getService(Ci.nsIXREDirProvider);
    1767 1767 
           // Flatpak does not support setting nor detection of default browser
    1768 
    -      if (!shellSvc || isInFlatpak || xreDirProvider.isPortableMode) {
    1768 
    +      // Mullvad Bug 298: the ability to set Mullvad as the default browser in
    1769 
    +      // Windows is currently not functioning so hide the DOM Element containing
    1770 
    +      // default browser settings on non-portable Windows installs as well
    1771 
    +      if (!shellSvc || isInFlatpak || xreDirProvider.isPortableMode || AppConstants.platform == "win") {
    1769 1772 
             defaultBrowserBox.hidden = true;
    1770 1773 
             return;
    1771 1774 
           }

  • browser/components/shell/ShellService.sys.mjs
    ... ... @@ -92,6 +92,13 @@ let ShellServiceInternal = {
    92 92 
        */
    93 93 
       _checkedThisSession: false,
    94 94 
       get shouldCheckDefaultBrowser() {
    95 
    +    // Mullvad Bug 298: the ability to set Mullvad as the default browser in
    96 
    +    // Windows is currently not functioning so in lieu of overwriting user prefs
    97 
    +    // or shipping a new default return early here
    98 
    +    if(AppConstants.platform == "win") {
    99 
    +      return false;
    100 
    +    }
    101 
    +
    95 102 
         // If we've already checked, the browser has been started and this is a
    96 103 
         // new window open, and we don't want to check again.
    97 104 
         if (this._checkedThisSession) {

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits