[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.12.0esr-13.5-1] fixup! Bug 40933: Add tor-launcher functionality

Title: GitLab

Pier Angelo Vendrame pushed to branch tor-browser-115.12.0esr-13.5-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 1d8abcb1
    by Pier Angelo Vendrame at 2024-06-12T16:01:14+02:00 
    fixup! Bug 40933: Add tor-launcher functionality

Bug 42636: A bad bridge line might get TBA stuck.

A while ago I reworked the relationship between TorSettings and
TorProvider. While doing so I was too strict, and a failure to push
settings during initialization will stop the initialization itself,
which will result in TBA stuck at the splash screen.

The problem appears also on desktop (the user will get a prompt that
asks to restart Tor, even though it is not perfect, see #21053).
However, on desktop the user can go to the settings and deleting the
bridges from there (which is not an optimal experience anyway).

1 changed file:

Changes:

  • toolkit/components/tor-launcher/TorProvider.sys.mjs
    ... ... @@ -232,11 +232,9 @@ export class TorProvider {
    232 232 
             await this.writeSettings(lazy.TorSettings.getSettings());
    233 233 
           } catch (e) {
    234 234 
             logger.warn(
    235 
    -          "Failed to initialize TorSettings or to write our settings, so uninitializing.",
    235 
    +          "Failed to initialize TorSettings or to write our initial settings. Continuing the initialization anyway.",
    236 236 
               e
    237 237 
             );
    238 
    -        this.uninit();
    239 
    -        throw e;
    240 238 
           }
    241 239 
         }
    242 240

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits