[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-152.0a1-16.0-2] fixup! BB 44711: Hide unwanted setting controls in Base Browser.



Title: GitLab

henry pushed to branch tor-browser-152.0a1-16.0-2 at The Tor Project / Applications / Tor Browser

Commits:

  • 81c2b390
    by Henry Wilkes at 2026-06-09T16:01:33+00:00
    fixup! BB 44711: Hide unwanted setting controls in Base Browser.
    
    BB 45043: Re-add missing changes to settings after 152 rebase.
    
    Drop changes to "addresses" and "payments" since these now properly
    hidden without the formautofill extension being in the build.
    

3 changed files:

Changes:

  • browser/components/preferences/config/passwords-autofill.mjs
    ... ... @@ -778,9 +778,6 @@ SettingGroupManager.registerGroups({
    778 778
         ],
    
    779 779
       },
    
    780 780
       managePayments: {
    
    781
    -    // Hide the payments settings. tor-browser#44460.
    
    782
    -    hidden: true,
    
    783
    -    hiddenFromSearch: true,
    
    784 781
         items: [
    
    785 782
           {
    
    786 783
             id: "add-payment-button",
    
    ... ... @@ -797,9 +794,6 @@ SettingGroupManager.registerGroups({
    797 794
         ],
    
    798 795
       },
    
    799 796
       manageAddresses: {
    
    800
    -    // Hide the addresses settings. tor-browser#44460.
    
    801
    -    hidden: true,
    
    802
    -    hiddenFromSearch: true,
    
    803 797
         items: [
    
    804 798
           {
    
    805 799
             id: "add-address-button",
    

  • browser/components/preferences/config/privacy.mjs
    ... ... @@ -2226,6 +2226,13 @@ Preferences.addSetting({
    2226 2226
       id: "relayIntegration",
    
    2227 2227
       deps: ["savePasswords", "relayFeature"],
    
    2228 2228
       visible: () => {
    
    2229
    +    // Hide Firefox Relay. tor-browser#43109 and tor-browser#42814.
    
    2230
    +    // NOTE: Whilst `FirefoxRelay.isDisabled` is `true` due to preferences we
    
    2231
    +    // set for Base Browser, `FirefoxRelay.isAvailable` is also `true` in this
    
    2232
    +    // case, hence why we still need to hide this unconditionally.
    
    2233
    +    if (lazy.AppConstants.BASE_BROWSER_VERSION) {
    
    2234
    +      return false;
    
    2235
    +    }
    
    2229 2236
         return lazy.FirefoxRelay.isAvailable;
    
    2230 2237
       },
    
    2231 2238
       disabled: ({ savePasswords, relayFeature }) => {
    
    ... ... @@ -3496,6 +3503,8 @@ Preferences.addSetting({
    3496 3503
     
    
    3497 3504
     Preferences.addSetting({
    
    3498 3505
       id: "etpStatusBoxGroup",
    
    3506
    +  // Hide enhanced tracking protection (ETP). tor-browser#26345.
    
    3507
    +  visible: () => false,
    
    3499 3508
     });
    
    3500 3509
     
    
    3501 3510
     Preferences.addSetting({
    
    ... ... @@ -3528,6 +3537,8 @@ Preferences.addSetting({
    3528 3537
     
    
    3529 3538
     Preferences.addSetting({
    
    3530 3539
       id: "protectionsDashboardLink",
    
    3540
    +  // Hide enhanced tracking protection (ETP). tor-browser#26345.
    
    3541
    +  visible: () => false,
    
    3531 3542
     });
    
    3532 3543
     
    
    3533 3544
     Preferences.addSetting({
    

  • browser/components/preferences/privacy.js
    ... ... @@ -641,12 +641,6 @@ var gPrivacyPane = {
    641 641
         initSettingGroup("onionSiteAuthentication");
    
    642 642
         initSettingGroup("certificates");
    
    643 643
         initSettingGroup("ipprotection");
    
    644
    -    // NOTE: "managePayments" and "manageAddresses" are usually initialised by
    
    645
    -    // FormAutofillPreferences.sys.mjs via FormAutofillStatus. But this never
    
    646
    -    // runs because the "autofill" extension is excluded from the build. So we
    
    647
    -    // initialise them ourselves with an empty config. See tor-browser#44630.
    
    648
    -    initSettingGroup("managePayments");
    
    649
    -    initSettingGroup("manageAddresses");
    
    650 644
         initSettingGroup("history");
    
    651 645
         initSettingGroup("history2");
    
    652 646
         initSettingGroup("permissions");
    

  • _______________________________________________
    tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
    To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx