[or-cvs] note an assert trigger bug

[arma@seul.org (Roger Dingledine)]

Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	connection_edge.c 
Log Message:
note an assert trigger bug
nick, want to fix this? :)


Index: connection_edge.c
===================================================================
RCS file: /home/or/cvsroot/src/or/connection_edge.c,v
retrieving revision 1.105
retrieving revision 1.106
diff -u -d -r1.105 -r1.106
--- connection_edge.c	29 Feb 2004 22:07:44 -0000	1.105
+++ connection_edge.c	1 Mar 2004 12:37:45 -0000	1.106
@@ -868,6 +868,13 @@
     case -1: /* resolve failed */
       log_fn(LOG_INFO,"Resolve failed (%s).", n_stream->address);
       connection_mark_for_close(n_stream, END_STREAM_REASON_RESOLVEFAILED);
+/* XXX BUG: we're in state RESOLVING here, but we haven't been added to the
+ * 'pending' list, because the dns lookup was already cached as failed.
+ * But the mark_for_close will try to remove us from the pending list,
+ * and we'll trigger an assert (dns.c line 209).
+ * Should we add another EXIT_CONN state? Should we put an exception
+ * here? Or there?
+ */
     /* case 0, resolve added to pending list */
   }
   return 0;