[tor-commits] [tor/maint-0.2.4] Clear up a comment about when an assertion could fire

[nickm@xxxxxxxxxxxxxx]

commit 5d2b2b9ede6ea0f247b5505d7e30a622c312e9fe
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue Feb 19 16:23:58 2013 -0500

    Clear up a comment about when an assertion could fire
    
    Resolves ticket 6164
---
 src/or/dirserv.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/or/dirserv.c b/src/or/dirserv.c
index badacd6..49fee88 100644
--- a/src/or/dirserv.c
+++ b/src/or/dirserv.c
@@ -2216,9 +2216,10 @@ routerstatus_format_entry(char *buf, size_t buf_len,
         return -1;
       }
 
-      /* This assert can fire for the control port, because
+      /* This assert could fire for the control port, because
        * it can request NS documents before all descriptors
-       * have been fetched. */
+       * have been fetched. Therefore, we only do this test when
+       * format != NS_CONTROL_PORT. */
       if (tor_memneq(desc->cache_info.signed_descriptor_digest,
             rs->descriptor_digest,
             DIGEST_LEN)) {



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits