[tor-commits] [tor/master] Don't assert when writing a cell to a CLOSING connection.

[nickm@xxxxxxxxxxxxxx]

commit ca50fb4f81a1f48c82d75825687085cda4627424
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue Mar 19 16:35:40 2013 -0400

    Don't assert when writing a cell to a CLOSING connection.
    
    Instead, drop the cell.
    
    Fixes another case of bug 7350; bugfix on 0.2.4.4-alpha
---
 changes/bug7350  |    4 ++++
 src/or/channel.c |   24 ++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/changes/bug7350 b/changes/bug7350
new file mode 100644
index 0000000..b0ee9d0
--- /dev/null
+++ b/changes/bug7350
@@ -0,0 +1,4 @@
+  o Major bugfixes:
+    - Avoid an assertion when we discover that we'd like to write a cell
+      onto a closing connection: just discard the cell. Fixes another
+      case of bug 7350; bugfix on 0.2.4.4-alpha.
diff --git a/src/or/channel.c b/src/or/channel.c
index 82db061..4e9086f 100644
--- a/src/or/channel.c
+++ b/src/or/channel.c
@@ -1751,6 +1751,14 @@ channel_write_cell(channel_t *chan, cell_t *cell)
   tor_assert(chan);
   tor_assert(cell);
 
+  if (chan->state == CHANNEL_STATE_CLOSING) {
+    log_debug(LD_CHANNEL, "Discarding cell_t %p on closing channel %p with "
+              "global ID "U64_FORMAT, cell, chan,
+              U64_PRINTF_ARG(chan->global_identifier));
+    tor_free(cell);
+    return;
+  }
+
   log_debug(LD_CHANNEL,
             "Writing cell_t %p to channel %p with global ID "
             U64_FORMAT,
@@ -1777,6 +1785,14 @@ channel_write_packed_cell(channel_t *chan, packed_cell_t *packed_cell)
   tor_assert(chan);
   tor_assert(packed_cell);
 
+  if (chan->state == CHANNEL_STATE_CLOSING) {
+    log_debug(LD_CHANNEL, "Discarding packed_cell_t %p on closing channel %p "
+              "with global ID "U64_FORMAT, packed_cell, chan,
+              U64_PRINTF_ARG(chan->global_identifier));
+    packed_cell_free(packed_cell);
+    return;
+  }
+
   log_debug(LD_CHANNEL,
             "Writing packed_cell_t %p to channel %p with global ID "
             U64_FORMAT,
@@ -1805,6 +1821,14 @@ channel_write_var_cell(channel_t *chan, var_cell_t *var_cell)
   tor_assert(chan);
   tor_assert(var_cell);
 
+  if (chan->state == CHANNEL_STATE_CLOSING) {
+    log_debug(LD_CHANNEL, "Discarding var_cell_t %p on closing channel %p "
+              "with global ID "U64_FORMAT, var_cell, chan,
+              U64_PRINTF_ARG(chan->global_identifier));
+    var_cell_free(var_cell);
+    return;
+  }
+
   log_debug(LD_CHANNEL,
             "Writing var_cell_t %p to channel %p with global ID "
             U64_FORMAT,



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits