[tor-commits] [tor/release-0.3.3] Allow alphanumeric TLDs in test for now

[nickm@xxxxxxxxxxxxxx]

commit d891010fdd4562e29a5a468232cd7b30430d7570
Author: rl1987 <rl1987@xxxxxxxxxxxxxxxx>
Date:   Tue Feb 20 19:52:48 2018 +0100

    Allow alphanumeric TLDs in test for now
---
 src/test/test_util.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index ef1f420fe..ee9b16494 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -5589,11 +5589,10 @@ test_util_hostname_validation(void *arg)
   tt_assert(!string_is_valid_hostname("[2a00:1450:401b:800::200e]"));
   tt_assert(!string_is_valid_hostname("2a00:1450:401b:800::200e"));
 
-  // Last label of a hostname is required to be alphabetic according to
-  // RFC 1123 Section 2.1.
-  tt_assert(!string_is_valid_hostname("lucky.13"));
-  tt_assert(!string_is_valid_hostname("luck.y13"));
-  tt_assert(!string_is_valid_hostname("luck.y13."));
+  // We allow alphanumeric TLDs. For discussion, see ticket #25055.
+  tt_assert(string_is_valid_hostname("lucky.13"));
+  tt_assert(string_is_valid_hostname("luck.y13"));
+  tt_assert(string_is_valid_hostname("luck.y13."));
 
   // We allow punycode TLDs. For examples, see
   // http://data.iana.org/TLD/tlds-alpha-by-domain.txt



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits