[tor-commits] [tor/master] test_router: Add comment to explain mocking

[asn@xxxxxxxxxxxxxx]

commit 7c9450fb073c8b5fb38dab826de7f0356c4828e2
Author: teor <teor@xxxxxxxxxxxxxx>
Date:   Thu Jan 10 17:12:15 2019 +1000

    test_router: Add comment to explain mocking
    
    Add comment in
    test_router_dump_router_to_string_no_bridge_distribution_method to explain
    the effect of a mocked function.
---
 src/test/test_router.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/test/test_router.c b/src/test/test_router.c
index ea0ee3e84..5477ab51e 100644
--- a/src/test/test_router.c
+++ b/src/test/test_router.c
@@ -100,6 +100,9 @@ test_router_dump_router_to_string_no_bridge_distribution_method(void *arg)
   router = (routerinfo_t*)router_get_my_routerinfo();
   tt_ptr_op(router, !=, NULL);
 
+  /* The real router_get_my_routerinfo() looks up onion_curve25519_pkey using
+   * get_current_curve25519_keypair(), but we don't initialise static data in
+   * this test. */
   router->onion_curve25519_pkey = &ntor_keypair.pubkey;
 
   /* Generate our server descriptor and ensure that the substring



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits