[tor-commits] [tor/master] Document why we build memwipe that way.

[nickm@xxxxxxxxxxxxxx]

commit fb999abea6edc99f151f546a7a4a60cf5b5f221b
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Thu May 12 12:56:47 2016 -0400

    Document why we build memwipe that way.
---
 src/test/include.am | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/test/include.am b/src/test/include.am
index b714152..d2909b2 100644
--- a/src/test/include.am
+++ b/src/test/include.am
@@ -170,8 +170,11 @@ src_test_test_slow_LDADD = $(src_test_test_LDADD)
 src_test_test_slow_LDFLAGS = $(src_test_test_LDFLAGS)
 
 src_test_test_memwipe_CPPFLAGS = $(src_test_test_CPPFLAGS)
+# Don't use bugtrap cflags here: memwipe tests require memory violations.
 src_test_test_memwipe_CFLAGS = $(TEST_CFLAGS)
 src_test_test_memwipe_LDADD = $(src_test_test_LDADD)
+# The LDFLAGS need to include the bugtrap cflags, or else we won't link
+# successfully with the libraries built with them.
 src_test_test_memwipe_LDFLAGS = $(src_test_test_LDFLAGS) @CFLAGS_BUGTRAP@
 
 src_test_bench_LDFLAGS = @TOR_LDFLAGS_zlib@ @TOR_LDFLAGS_openssl@ \



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits