[tor-commits] [atlas/master] Improves the "Not recommended" tooltip text

[irl@xxxxxxxxxxxxxx]

commit abd945a809090e248e5690c901ff80aadef158c2
Author: Iain R. Learmonth <irl@xxxxxxxx>
Date:   Fri May 19 00:22:20 2017 +0100

    Improves the "Not recommended" tooltip text
    
     * This renames the "Not recommended" property to "Outdated Tor Version"
     * The description is amended to also point out that a version may be not
       recommended because it has known issues
    
    Fixes: #22294
---
 templates/details/bridge.html | 4 ++--
 templates/details/router.html | 4 ++--
 templates/search/do.html      | 6 +++++-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/templates/details/bridge.html b/templates/details/bridge.html
index c2e5b80..c4b93c0 100644
--- a/templates/details/bridge.html
+++ b/templates/details/bridge.html
@@ -65,9 +65,9 @@
     <% if (relay.get('recommended_version') === false) {
         propertyCount++;
         %>
-        <span class="tip flags" title="This relay is running a software version that is not recommended by the directory authorities.">
+        <span class="tip flags" title="This bridge is running a Tor version that is not recommended by the directory authorities and may contain known issues.">
             <img class="inline" alt="" src="img/properties/not_recommended_16x16.png"/>
-            <span class="inline">Not recommended</span>
+            <span class="inline">Outdated Tor version</span>
         </span>
     <% } %>
     <%=propertyCount==0?'none':''%>
diff --git a/templates/details/router.html b/templates/details/router.html
index 7ea26bf..76b8ff6 100644
--- a/templates/details/router.html
+++ b/templates/details/router.html
@@ -97,9 +97,9 @@
     <% if (relay.get('recommended_version') === false) {
         propertyCount++;
         %>
-        <span class="tip flags" title="This relay is running a software version that is not recommended by the directory authorities.">
+        <span class="tip flags" title="This relay is running a Tor version that is not recommended by the directory authorities and may contain known issues.">
             <img class="inline" alt="" src="img/properties/not_recommended_16x16.png"/>
-            <span class="inline">Not recommended</span>
+            <span class="inline">Outdated Tor version</span>
         </span>
     <% } %>
     <%=propertyCount==0?'none':''%>
diff --git a/templates/search/do.html b/templates/search/do.html
index a117d0e..56d8396 100644
--- a/templates/search/do.html
+++ b/templates/search/do.html
@@ -108,7 +108,11 @@
             </td>
             <td>
             <% if (relay.get('recommended_version') === false) { %>
-                <img class="tip inline flags" src="img/properties/not_recommended_16x16.png" alt="Not recommended" title="Not recommended<br />This relay is running a software version that is not recommended by the directory authorities."/>
+                <% if (relay.get('is_bridge')) { %>
+                <img class="tip" src="img/properties/not_recommended_16x16.png" alt="Outdated Tor version" title="Outdated Tor version<br />This bridge is running a Tor version that is not recommended by the directory authorities and may contain known issues."/>
+                <% } else { %>
+                <img class="tip" src="img/properties/not_recommended_16x16.png" alt="Outdated Tor version" title="Outdated Tor version<br />This relay is running a Tor version that is not recommended by the directory authorities and may contain known issues."/>
+                <% } %>
             <% } %>
             </td>
 			<td><%= relay.get('or_port') %></td>



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits