[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-151.0a1-16.0-1] fixup! TB 40933: Add tor-launcher functionality

Title: GitLab

Pier Angelo Vendrame pushed to branch tor-browser-151.0a1-16.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 3bc02e6b
    by Pier Angelo Vendrame at 2026-05-26T16:54:01+02:00 
    fixup! TB 40933: Add tor-launcher functionality

TB 44991: Improve the no-authentication handling on the control port.

2 changed files:

Changes:

  • toolkit/components/tor-launcher/TorControlPort.sys.mjs
    ... ... @@ -672,6 +672,8 @@ export class TorController {
    672 672 
       /**
    673 673 
        * Authenticate to the tor daemon.
    674 674 
        * Notice that a failure in the authentication makes the connection close.
    675 
    +   * This function tolerates empty and false-ish passwords because a client
    676 
    +   * needs to authenticate even when all authentication methods are disabled.
    675 677 
        *
    676 678 
        * @param {Uint8Array} password The password for the control port, as an array
    677 679 
        * of bytes
    ... ... @@ -680,7 +682,11 @@ export class TorController {
    680 682 
         const passwordString = Array.from(password ?? [], b =>
    681 683 
           b.toString(16).padStart(2, "0")
    682 684 
         ).join("");
    683 
    -    await this.#sendCommandSimple(`authenticate ${passwordString}`);
    685 
    +    let command = "AUTHENTICATE";
    686 
    +    if (passwordString) {
    687 
    +      command += ` ${passwordString}`;
    688 
    +    }
    689 
    +    await this.#sendCommandSimple(command);
    684 690 
       }
    685 691
    686 692 
       // Information

  • toolkit/components/tor-launcher/TorProvider.sys.mjs
    ... ... @@ -834,6 +834,9 @@ export class TorProvider extends TorProviderBase {
    834 834 
               this.#controlPortSettings.cookieFilePath
    835 835 
             );
    836 836 
           }
    837 
    +      // As per the spec, we must always authenticate to the control port, even
    838 
    +      // when all authentication methods are disabled.
    839 
    +      // https://spec.torproject.org/control-spec/commands.html#authenticate
    837 840 
           await controlPort.authenticate(password);
    838 841 
         } catch (e) {
    839 842 
           try {

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3bc02e6b913cd689f1e81e5d26a5633446040f50 at 1779807548 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx