[or-cvs] r17249: {tor} Backport: Fix from rovv: when adding a detached signature, d (in tor/branches/tor-0_2_0-patches: . src/or)

[nickm@xxxxxxxx]

Author: nickm
Date: 2008-11-11 11:36:03 -0500 (Tue, 11 Nov 2008)
New Revision: 17249

Modified:
   tor/branches/tor-0_2_0-patches/ChangeLog
   tor/branches/tor-0_2_0-patches/src/or/dirvote.c
Log:
Backport: Fix from rovv: when adding a detached signature, do not automatically assume it is good just because we are adding it.  We might also be adding it because it was the first signature we saw for a given voter.

Modified: tor/branches/tor-0_2_0-patches/ChangeLog
===================================================================
--- tor/branches/tor-0_2_0-patches/ChangeLog	2008-11-11 16:35:46 UTC (rev 17248)
+++ tor/branches/tor-0_2_0-patches/ChangeLog	2008-11-11 16:36:03 UTC (rev 17249)
@@ -1,4 +1,8 @@
 Changes in version 0.2.0.32 - 2008-??-??
+  o Major bugfixes:
+    - Fix a DOS opportunity during the voting signature collection process
+      at directory authorities. Spotted by rovv. Bugfix on 0.2.0.x.
+
   o Minor bugfixes:
     - Fix several infrequent memory leaks spotted by Coverity.
     - When testing for libevent functions, set the LDFLAGS variable

Modified: tor/branches/tor-0_2_0-patches/src/or/dirvote.c
===================================================================
--- tor/branches/tor-0_2_0-patches/src/or/dirvote.c	2008-11-11 16:35:46 UTC (rev 17248)
+++ tor/branches/tor-0_2_0-patches/src/or/dirvote.c	2008-11-11 16:36:03 UTC (rev 17249)
@@ -1089,8 +1089,8 @@
         memcpy(target_voter->signing_key_digest, src_voter->signing_key_digest,
                DIGEST_LEN);
         target_voter->signature_len = src_voter->signature_len;
-        target_voter->good_signature = 1;
-        target_voter->bad_signature = 0;
+        target_voter->good_signature = src_voter->good_signature;
+        target_voter->bad_signature = src_voter->bad_signature;
       } else {
         log_info(LD_DIR, "Not adding signature from %s", voter_identity);
       }